Skip to content

added code review wg video #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

added code review wg video #1807

merged 1 commit into from
Oct 14, 2025

Conversation

JeffCarver
Copy link
Contributor

@JeffCarver JeffCarver commented Oct 14, 2025 •
edited
Loading

Description

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@JeffCarver
Copy link
Contributor Author

Preview: https://output.circle-artifacts.com/output/job/c0661660-385a-4c9f-9c9c-b6da4d7a7e87/artifacts/0/usrse.github.io/wg/code-review/index.html

@JeffCarver
Copy link
Contributor Author

This PR adds the first code review demo to the Code Review WG page.

roelofsaj
roelofsaj approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@roelofsaj roelofsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me--thanks Jeff!

exoticDFT
exoticDFT approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@exoticDFT exoticDFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffCarver JeffCarver merged commit 51fef59 into main Oct 14, 2025
2 checks passed
@JeffCarver JeffCarver deleted the code-review-wg-video branch October 14, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roelofsaj roelofsaj roelofsaj approved these changes

@exoticDFT exoticDFT exoticDFT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeffCarver @roelofsaj @exoticDFT