-
Notifications
You must be signed in to change notification settings - Fork 19
125 create semester course components #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed a system to dynamically allow users to move a course to a new semester (only changes options for now, doesnt work yet)
…b.com/UMLCloudComputing/UniPath.io into 125-create-semester-course-components
…ble components as they didnt work well with dnd
…handling function. even though the function is outputting the correct array, the list still reverts after dropping the draggable.
Co-authored-by: Martin Marwad <MartinMarwad@users.noreply.github.com>
… with typescript and the schema. in the meantime i worked on the add course dialog which is very basic right now
Build check completed! View branch preview: https://125-create-semester-course-components.d3c5lsis3camij.amplifyapp.com/ |
MartinMarwad
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created semester and course components and implemented drag and drop between them. I wanted to just make a PR for everything that I have done over the past few months even though I'm not finished.