Feature/abzu 252893 aio big update issue #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `FulfilmentDataService.cs`, added ordering by `EditionNumber` to prioritize the most recent product version when searching by name. - In `AzureTableStorageHelper.cs`, simplified the query by removing the `EditionNumber` condition, which may lead to retrieving outdated product versions.
Enhanced `FulfilmentDataService.cs` with logging statements to track the start and completion of retrieving product versions from entities. Updated the check for result list to use `result.Count > 0`. Introduced new event IDs in `EventIds.cs` for logging the start and completion events of the retrieval process.
- Introduced a new using directive for TableEntities. - Added static readonly string `_aioProductName` for better maintainability. - Updated test method to call `_fakeAzureTableStorageHelper.GetLatestProductVersionDetails()`. - Refined matching conditions in `_fakeEssService.GetProductDataProductVersions`. - Added `GetProductVersionEntities` method to encapsulate test data.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
DanOwenUKHO
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.