Skip to content

Feature/abzu 220298 serial aio week update fix #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Feature/abzu 220298 serial aio week update fix #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaaab4f
Update zip creation logic and related tests
JiviteshT Jun 10, 2025
2b2c129
Abzu
JiviteshT Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...O.AdmiraltyInformationOverlay.Fulfilment.UnitTests/Services/FulfilmentDataServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public async Task Does_CreateAioExchangeSets_Executes_Successfully()
.MustHaveHappenedOnceExactly();

A.CallTo(() => _fakefileSystemHelper.CreateZipFile(A<string>.Ignored, A<string>.Ignored, A<bool>.Ignored))
.MustHaveHappenedOnceExactly();
.MustHaveHappened(2, Times.Exactly);

A.CallTo(() => _fakeFssService.WriteBlockFile(A<string>.Ignored, A<string>.Ignored, A<IEnumerable<string>>.Ignored, A<string>.Ignored))
.MustHaveHappenedOnceOrMore();
Expand Down Expand Up @@ -219,13 +219,7 @@ public async Task Does_CreateAioExchangeSets_Executes_Successfully()
call.Method.Name == "Log"
&& call.GetArgument<LogLevel>(0) == LogLevel.Information
&& call.GetArgument<IEnumerable<KeyValuePair<string, object>>>(2).ToDictionary(c => c.Key, c => c.Value)["{OriginalFormat}"].ToString() == "Creating zip file of directory {fileName} started at {DateTime} | _X-Correlation-ID:{CorrelationId}"
).MustHaveHappenedOnceExactly();

A.CallTo(_fakeLogger).Where(call =>
call.Method.Name == "Log"
&& call.GetArgument<LogLevel>(0) == LogLevel.Information
&& call.GetArgument<IEnumerable<KeyValuePair<string, object>>>(2).ToDictionary(c => c.Key, c => c.Value)["{OriginalFormat}"].ToString() == "Creating zip file of directory {fileName} completed at {DateTime} | _X-Correlation-ID:{CorrelationId}"
).MustHaveHappenedOnceExactly();
).MustHaveHappened(2, Times.Exactly);

#endregion Log checks
}
Expand Down
1 change: 1 addition & 0 deletions ...tputService/UKHO.AdmiraltyInformationOverlay.Fulfilment/Services/FulfilmentDataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ private async Task CreateUpdateAIOExchangeSet(List<ProductVersionEntities> produ
ExtractExchangeSetZip(essFiles, essFileDownloadPath);
UpdateSerialAioFile(essFiles, essFileDownloadPath, "UPDATE", weekNumber);
var latestProductVersions = GetTheLatestUpdateNumber(essFileDownloadPath, aioCellNames, weekNumber);
CreateExchangeSetZip(essFiles, essFileDownloadPath);
isUpdateZipBatchCreated = await CreatePosBatch(essFileDownloadPath, UPDATEZIPEXCHANGESETFILEEXTENSION, Batch.AioUpdateZipBatch, weekNumber);

if (isUpdateZipBatchCreated)
Expand Down