Process AIO weeks to increment and update file names #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…176930-aio-week-number2
…-176930-aio-week-number4
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
JiviteshT
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Allow week number to be adjusted on calculation * Update year / week calculations * Update editorconfig * Rework week number calculations * Pass week number details through code * Calculate week number up front * Rename * Small fix * Update AIO file names * Test update * Revert spacing * Set weeks to increment value * Update tests to match new file names * Update functional tests and stub * Fix for week numbers in testing * Reinstate accidentally removed code * Further fix * And another fix * Add parameter to functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
Code cleanup and new feature
PR Summary
This PR introduces new configuration options and coding style rules, refactors code for better readability, and adds a new
FormattedWeekNumbermodel for week and year calculations.GetWeekNumbermethod and refactoredGetBatchDetails.FormattedWeekNumberand improved readability.WeeksToIncrementsetting.