Skip to content

Conversation

@JiviteshT
Copy link
Contributor

No description provided.

- Added `azurerm_storage_table` resource for AIO configurations in Terraform.
- Introduced new output variables for storage account access key and connection string.
- Added variables for AIO job configurations in `variables.tf`.
- Updated `main.tf` to include AIO weekly and printing configurations.
- Added `InsertAioJobConfigurationEntityInTable` job in `app-deploy.yml`.
- Enhanced `continuous-deployment.yml` with steps for AIO job variables and config transformations.
- Updated `build-test-publish.yml` for publishing AIO Fulfilment Service code.
- Modified `terraform_conditional_run.ps1` to set new output variables.
- Updated `Program.cs` to include `Microsoft.Extensions.Azure` and configuration adjustments.
- Added AIO job configuration properties to `appsettings.json`.
- Changed schedule in `settings.job`.
- Updated `FssServiceTests.cs` to mock `IAzureTableStorageHelper`.
- Added properties to `AzureStorageConfiguration.cs` for AIO table names.
- Enhanced `AzureTableStorageHelper.cs` to use new table names and fetch AIO job configurations.
- Updated `FssService.cs` to use `IAzureTableStorageHelper` for AIO configurations.
- Added `AioJobConfigurationEntities` class for AIO job entities in Azure Table Storage.
- Minor formatting and consistency adjustments across various files.
- Updated `azurerm_storage_account` resource `pos_storage` to include an additional subnet ID in `virtual_network_subnet_ids`.
- Modified `azurerm_storage_table` resource `aio_config_table` to use `var.aio_config_table_name` for its `name` attribute.
- Updated `agent_2204_subnet` variable and renamed `table_name` to `aio_config_table_name` in `variables.tf`.
- Removed `aio_weekly_configuration` and `aio_printing_configuration` variables from `webapp_service` module in `main.tf` and added `aio_config_table_name`.
- Updated `continuous-deployment.yml` to remove environment variables related to `aio_weekly_configuration` and `aio_printing_configuration`, and added `TF_VAR_aio_config_table_name`.
Added new test cases in `FssServiceTests.cs` to verify the `CreateBatch` method for different batch types and configurations. Updated `using` directives in `FssServiceTests.cs` and `AzureTableStorageHelper.cs` to include necessary namespaces and remove unused ones. Removed a commented-out constant in `AzureTableStorageHelper.cs`. Cleaned up `AioJobConfigurationEntities.cs` by removing unnecessary `using` directives. Marked `AddBatchAttributesForAio` method in `FssService.cs` with `[ExcludeFromCodeCoverage]`.
@JiviteshT JiviteshT requested review from a team and rockydevnet as code owners February 4, 2025 12:02
@snyk-io
Copy link

snyk-io bot commented Feb 4, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@hukho hukho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JiviteshT JiviteshT merged commit 8cdafb8 into main Feb 4, 2025
20 of 22 checks passed
@JiviteshT JiviteshT deleted the ABZU-197389-cd-printing branch February 4, 2025 15:38
JiviteshT added a commit that referenced this pull request Mar 3, 2025
* Abzu-197389-Added azure table to store AIO job configuration

- Added `azurerm_storage_table` resource for AIO configurations in Terraform.
- Introduced new output variables for storage account access key and connection string.
- Added variables for AIO job configurations in `variables.tf`.
- Updated `main.tf` to include AIO weekly and printing configurations.
- Added `InsertAioJobConfigurationEntityInTable` job in `app-deploy.yml`.
- Enhanced `continuous-deployment.yml` with steps for AIO job variables and config transformations.
- Updated `build-test-publish.yml` for publishing AIO Fulfilment Service code.
- Modified `terraform_conditional_run.ps1` to set new output variables.
- Updated `Program.cs` to include `Microsoft.Extensions.Azure` and configuration adjustments.
- Added AIO job configuration properties to `appsettings.json`.
- Changed schedule in `settings.job`.
- Updated `FssServiceTests.cs` to mock `IAzureTableStorageHelper`.
- Added properties to `AzureStorageConfiguration.cs` for AIO table names.
- Enhanced `AzureTableStorageHelper.cs` to use new table names and fetch AIO job configurations.
- Updated `FssService.cs` to use `IAzureTableStorageHelper` for AIO configurations.
- Added `AioJobConfigurationEntities` class for AIO job entities in Azure Table Storage.
- Minor formatting and consistency adjustments across various files.

* Update storage, variables, and CI configuration

- Updated `azurerm_storage_account` resource `pos_storage` to include an additional subnet ID in `virtual_network_subnet_ids`.
- Modified `azurerm_storage_table` resource `aio_config_table` to use `var.aio_config_table_name` for its `name` attribute.
- Updated `agent_2204_subnet` variable and renamed `table_name` to `aio_config_table_name` in `variables.tf`.
- Removed `aio_weekly_configuration` and `aio_printing_configuration` variables from `webapp_service` module in `main.tf` and added `aio_config_table_name`.
- Updated `continuous-deployment.yml` to remove environment variables related to `aio_weekly_configuration` and `aio_printing_configuration`, and added `TF_VAR_aio_config_table_name`.

* Add tests for CreateBatch and clean up code

Added new test cases in `FssServiceTests.cs` to verify the `CreateBatch` method for different batch types and configurations. Updated `using` directives in `FssServiceTests.cs` and `AzureTableStorageHelper.cs` to include necessary namespaces and remove unused ones. Removed a commented-out constant in `AzureTableStorageHelper.cs`. Cleaned up `AioJobConfigurationEntities.cs` by removing unnecessary `using` directives. Marked `AddBatchAttributesForAio` method in `FssService.cs` with `[ExcludeFromCodeCoverage]`.

* Updated product version details table in app setting and schedule time in settings.job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants