-
Notifications
You must be signed in to change notification settings - Fork 2
Abzu 197389 cd printing #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `azurerm_storage_table` resource for AIO configurations in Terraform. - Introduced new output variables for storage account access key and connection string. - Added variables for AIO job configurations in `variables.tf`. - Updated `main.tf` to include AIO weekly and printing configurations. - Added `InsertAioJobConfigurationEntityInTable` job in `app-deploy.yml`. - Enhanced `continuous-deployment.yml` with steps for AIO job variables and config transformations. - Updated `build-test-publish.yml` for publishing AIO Fulfilment Service code. - Modified `terraform_conditional_run.ps1` to set new output variables. - Updated `Program.cs` to include `Microsoft.Extensions.Azure` and configuration adjustments. - Added AIO job configuration properties to `appsettings.json`. - Changed schedule in `settings.job`. - Updated `FssServiceTests.cs` to mock `IAzureTableStorageHelper`. - Added properties to `AzureStorageConfiguration.cs` for AIO table names. - Enhanced `AzureTableStorageHelper.cs` to use new table names and fetch AIO job configurations. - Updated `FssService.cs` to use `IAzureTableStorageHelper` for AIO configurations. - Added `AioJobConfigurationEntities` class for AIO job entities in Azure Table Storage. - Minor formatting and consistency adjustments across various files.
- Updated `azurerm_storage_account` resource `pos_storage` to include an additional subnet ID in `virtual_network_subnet_ids`. - Modified `azurerm_storage_table` resource `aio_config_table` to use `var.aio_config_table_name` for its `name` attribute. - Updated `agent_2204_subnet` variable and renamed `table_name` to `aio_config_table_name` in `variables.tf`. - Removed `aio_weekly_configuration` and `aio_printing_configuration` variables from `webapp_service` module in `main.tf` and added `aio_config_table_name`. - Updated `continuous-deployment.yml` to remove environment variables related to `aio_weekly_configuration` and `aio_printing_configuration`, and added `TF_VAR_aio_config_table_name`.
Added new test cases in `FssServiceTests.cs` to verify the `CreateBatch` method for different batch types and configurations. Updated `using` directives in `FssServiceTests.cs` and `AzureTableStorageHelper.cs` to include necessary namespaces and remove unused ones. Removed a commented-out constant in `AzureTableStorageHelper.cs`. Cleaned up `AioJobConfigurationEntities.cs` by removing unnecessary `using` directives. Marked `AddBatchAttributesForAio` method in `FssService.cs` with `[ExcludeFromCodeCoverage]`.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
…e in settings.job
hukho
approved these changes
Feb 4, 2025
Contributor
hukho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
JiviteshT
added a commit
that referenced
this pull request
Mar 3, 2025
* Abzu-197389-Added azure table to store AIO job configuration - Added `azurerm_storage_table` resource for AIO configurations in Terraform. - Introduced new output variables for storage account access key and connection string. - Added variables for AIO job configurations in `variables.tf`. - Updated `main.tf` to include AIO weekly and printing configurations. - Added `InsertAioJobConfigurationEntityInTable` job in `app-deploy.yml`. - Enhanced `continuous-deployment.yml` with steps for AIO job variables and config transformations. - Updated `build-test-publish.yml` for publishing AIO Fulfilment Service code. - Modified `terraform_conditional_run.ps1` to set new output variables. - Updated `Program.cs` to include `Microsoft.Extensions.Azure` and configuration adjustments. - Added AIO job configuration properties to `appsettings.json`. - Changed schedule in `settings.job`. - Updated `FssServiceTests.cs` to mock `IAzureTableStorageHelper`. - Added properties to `AzureStorageConfiguration.cs` for AIO table names. - Enhanced `AzureTableStorageHelper.cs` to use new table names and fetch AIO job configurations. - Updated `FssService.cs` to use `IAzureTableStorageHelper` for AIO configurations. - Added `AioJobConfigurationEntities` class for AIO job entities in Azure Table Storage. - Minor formatting and consistency adjustments across various files. * Update storage, variables, and CI configuration - Updated `azurerm_storage_account` resource `pos_storage` to include an additional subnet ID in `virtual_network_subnet_ids`. - Modified `azurerm_storage_table` resource `aio_config_table` to use `var.aio_config_table_name` for its `name` attribute. - Updated `agent_2204_subnet` variable and renamed `table_name` to `aio_config_table_name` in `variables.tf`. - Removed `aio_weekly_configuration` and `aio_printing_configuration` variables from `webapp_service` module in `main.tf` and added `aio_config_table_name`. - Updated `continuous-deployment.yml` to remove environment variables related to `aio_weekly_configuration` and `aio_printing_configuration`, and added `TF_VAR_aio_config_table_name`. * Add tests for CreateBatch and clean up code Added new test cases in `FssServiceTests.cs` to verify the `CreateBatch` method for different batch types and configurations. Updated `using` directives in `FssServiceTests.cs` and `AzureTableStorageHelper.cs` to include necessary namespaces and remove unused ones. Removed a commented-out constant in `AzureTableStorageHelper.cs`. Cleaned up `AioJobConfigurationEntities.cs` by removing unnecessary `using` directives. Marked `AddBatchAttributesForAio` method in `FssService.cs` with `[ExcludeFromCodeCoverage]`. * Updated product version details table in app setting and schedule time in settings.job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.