feat(ui5-flexible-column-layout): public layoutsConfiguration property #9290
Conversation
|
As synced offline, the layoutsConfiguration is now a public property that is being changed by the component upon user interaction, it would help to fire an event and notify the application about those changes. |
| return false; | ||
| } | ||
|
|
||
| const hasColumnBelowMinWidth = pxWidths.some(pxWidth => { |
There was a problem hiding this comment.
Not sure whether this could cause an issue but it seems that this check returns false whenever we have less than 3 columns because of their 0 width.
There was a problem hiding this comment.
yes, this issue had popped up earlier, this is why the check for width also contained pxWidth > 0
| this.layout = newLayout; | ||
| this.fireLayoutChange(true, false); | ||
| } | ||
| if (oldColumnLayout !== newColumnLayout) { |
There was a problem hiding this comment.
Those two seems to be arrays, comparing them with "===" will compare them by reference and would result in false. Unless this is intentional, we may need to deep check if the fields have changed.
There was a problem hiding this comment.
thanks, corrected now to compare the actual content
…umns below min-width
kineticjs
force-pushed
the
fcl-layout-config-api
branch
from
535761b to
8f6514e
Compare
|
|
kineticjs
force-pushed
the
fcl-layout-config-api
branch
from
f4411e2 to
fd5dd40
Compare
| * @param {MEDIA} media The current media type | ||
| * @param {array} columnLayout The effective column layout, f.e ["67%", "33%", "0px"] | ||
| * @public | ||
| * @since 2.15.1 |
There was a problem hiding this comment.
Not sure about the correct version
| * - Whenever the user drags the columns separator to resize the columns, the `layoutsConfiguration` object will be updated with the user-specified proportions for the given layout (and the `layout-configuration-change` event will be fired). | ||
| * - No custom configuration available for the phone screen size, as the default of 100% column width is always used there. | ||
| * @public | ||
| * @since 2.15.1 |
There was a problem hiding this comment.
Not sure about the correct version (2.15.1?)
3 participants
Add public layoutsConfiguration property to allow the app customize the column proportions per screen size and layout.
Also, update the layoutsConfiguration fields whenever the user interactively changes the column proportions by dragging the columns separator.