Skip to content

Conversation

aleksandar-terziev
Copy link
Contributor

@aleksandar-terziev aleksandar-terziev commented Oct 17, 2025

JIRA: BGSOFUIRILA-4156

Prevent validation rollback from interrupting IME input composition by skipping
validation until composition ends. Update tests for
Korean/Japanese/Chinese composition scenarios.

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Oct 17, 2025

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 17, 2025 14:49 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 20, 2025 06:45 Inactive
@ndeshev ndeshev requested a review from Copilot October 21, 2025 18:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the MultiComboBox component incorrectly validates and rejects input during IME (Input Method Editor) composition for languages like Korean, Japanese, and Chinese. The fix prevents validation from running while composition is in progress, ensuring that intermediate composition states don't trigger error states or clear the input prematurely.

Key Changes

  • Modified validation logic to skip when composition is active (_isComposing flag)
  • Adjusted when _inputLastValue is updated to exclude composition states
  • Moved valueBeforeAutoComplete assignment inside composition check to preserve typed text
  • Refactored tests to use helper functions and added comprehensive validation scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/main/src/MultiComboBox.ts Added composition guards to validation logic and input tracking
packages/main/test/pages/MultiComboBox.html Added test cases for Korean and Chinese with validation
packages/main/cypress/specs/MultiComboBox.cy.tsx Refactored composition tests with helpers and added validation coverage

@ndeshev
Copy link
Contributor

ndeshev commented Oct 21, 2025

Looks good to me. Add a bit of information about the PR in the description, like "prevent validation and typeahead during composite language input". Add a JIRA reference (BGSOFUIRILA-4156) for traceability. Check the copilot suggestions for small improvements above.

JIRA: BGSOFUIRILA-4156

Prevent validation rollback from interrupting IME composition input stages by skipping
validation until compositionend. Update test coverage for
Korean/Japanese/Chinese composition scenarios.
@aleksandar-terziev aleksandar-terziev force-pushed the multi-combo-ime-validation branch from 179a550 to 23a708f Compare October 22, 2025 09:30
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 22, 2025 09:36 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 22, 2025 16:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants