feat(ui5-ai-input): introduce new component #12407
Open
+1,713
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial poc draft, all naming and logic are work in progress and subject to change
initial poc draft, all naming and logic are work in progress and subject to change BGSOFUIRILA-4032
delete unwanted file
refactor, add tests
restore textarea template
remove 'SingleResult' and 'MultipleResults' properties from AssistantState.ts adapt the implementation to use the totalVersions count internally to control the state
fix build errors
major API and structure refactoring
accessibility improvements
fix errors and bugs
fix test naming issues
…into ai-textarea
fix test file name
…into ai-textarea
code cleanup
rename test file
fix cypress tests
use plain toolbar button, adjust tests, clean up styles
apply code review suggestions
StefanDimitrov04
force-pushed
the
ai-input
branch
from
606297d to
72b6443
Compare
StefanDimitrov04
changed the title
|
🚀 Deployed on https://pr-12407--ui5-webcomponents-preview.netlify.app |
|
Some interaction remarks:
|
nikoletavnv
requested changes
Oct 15, 2025
| </Menu> | ||
| </div> | ||
| </div> | ||
| {InputPopoverTemplate.call(this, { suggestionsList })} |
There was a problem hiding this comment.
Do we need suggestions at this point? We can disable them when inheriting from the Input component and add them later in case we need them for the AI Input
| <> | ||
| <span id="suggestionsText" class="ui5-hidden-text">{this.suggestionsText}</span> | ||
| <span id="selectionText" class="ui5-hidden-text" aria-live="polite" role="status"></span> | ||
| <span id="suggestionsCount" class="ui5-hidden-text" aria-live="polite">{this.availableSuggestionsCount}</span> |
There was a problem hiding this comment.
Remove the suggestions related aria-live elements
nikoletavnv
requested changes
Oct 16, 2025
| describe("Basic", () => { | ||
| describe("Initialization", () => { | ||
| it("should render with default properties", () => { | ||
| cy.mount(<AIInput />); |
There was a problem hiding this comment.
When I render an AI Input without any menu items in the slot, the AI icon is present and when I click on it - an empty menu item with no text appears. Maybe it is better to not render ghost menu item in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRILA-4104