Skip to content

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Apr 11, 2025

Upgrades an UI5 version definied in following properties:

  • sap.platform.cf/ui5VersionNumber
  • sap.cloud.portal/ui5VersionNumber

Fixes #15

…mmonDataModel.json

Upgrades an UI5 version definied in following properties:
- "sap.platform.cf/ui5VersionNumber"
- "sap.cloud.portal/ui5VersionNumber"
@flovogt flovogt changed the title feat(sapui5): Upgrade a UI5 version maintained in manifest.json or CommonDataModel.json feat(sapui5): Upgrade UI5 version maintained in manifest.json or CommonDataModel.json Apr 11, 2025
@flovogt
Copy link
Member Author

flovogt commented Apr 11, 2025

I tested the config in https://github.com/flovogt/openui5-sample-app/pulls. As you see, the project uses OpenUI5 as the framework. However, SAP products related to launchpad services only use SAPUI5 as a framework, so UI5 versions defined in manifest.json and CommonDataModel.json should only point to SAPUI5 releases.

@flovogt flovogt mentioned this pull request Apr 11, 2025
@flovogt flovogt marked this pull request as ready for review April 14, 2025 05:25
@flovogt flovogt merged commit 6c877cf into main Apr 16, 2025
5 checks passed
@flovogt flovogt deleted the manifest-support-ui5versionnumber branch April 16, 2025 18:20
@openui5bot openui5bot mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offer version replacements for relevant properties in manifest.json

2 participants