Skip to content

Quarto mod7 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 3, 2025
Merged

Quarto mod7 #51

merged 10 commits into from
Jun 3, 2025

Conversation

zmx721
Copy link
Contributor

@zmx721 zmx721 commented May 2, 2025

Here is the PR for module 7.

  • I had to ask students to do one thing to pass the checks and another to view the results in quite a few of the coding questions.
    • For example, in Exercise 2.1, the last line outputs a dict so that result is not None and we can test it. However, printing the string version of the report is easier for students to interpret the results.

Screenshot 2025-05-01 at 8 16 37 PM

  • I do not know what happened to Exercise 5.1. The set up code block was not working locally or in the PR review. I redid it in a new file, and everything is magically working now. (Hope the spell's duration is set to infinity.)
    • Exercise 6.1 had the same issue, but I made a few mistakes, so maybe those caused the original issue.

@zmx721 zmx721 marked this pull request as draft May 2, 2025 02:11
Copy link

github-actions bot commented May 2, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-03 08:29 UTC

@zmx721 zmx721 requested a review from joelostblom May 2, 2025 03:18
@zmx721 zmx721 marked this pull request as ready for review May 2, 2025 03:19
@joelostblom
Copy link
Collaborator

I had to ask students to do one thing to pass the checks and another to view the results in quite a few of the coding questions. For example, in Exercise 2.1, the last line outputs a dict so that result is not None and we can test it. However, printing the string version of the report is easier for students to interpret the results.

I don't see a better way of doing this unfortunately. Converting to a dataframe almost works, but it gets messed up where there are missing sub-keys in the dict. As long as the comments are clear for the students we can stay with this.

I do not know what happened to Exercise 5.1. The set up code block was not working locally or in the PR review. I redid it in a new file, and everything is magically working now. (Hope the spell's duration is set to infinity.)

Works for me too!

@joelostblom joelostblom requested a review from sandygross May 30, 2025 17:48

<iframe
class="video"
src="https://www.youtube.com/embed/85AnZNWixlg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video isn’t trimmed — it’s 50 seconds long, but only the first 18 seconds are actually relevant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelostblom You re-uploaded the videos, right? Will you be able to fix this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forwarded this request to the people trimming the videos for us. We can merge this PR and follow up on that separately.

@zmx721
Copy link
Contributor Author

zmx721 commented Jun 2, 2025

@joelostblom @sandygross All comments except for the outro video has been resolved. Thank you!

@joelostblom joelostblom merged commit 967b224 into main Jun 3, 2025
1 check passed
@joelostblom joelostblom deleted the quarto_mod7 branch June 3, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants