-
Notifications
You must be signed in to change notification settings - Fork 6
Quarto mod7 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarto mod7 #51
Conversation
|
I don't see a better way of doing this unfortunately. Converting to a dataframe almost works, but it gets messed up where there are missing sub-keys in the dict. As long as the comments are clear for the students we can stay with this.
Works for me too! |
|
||
<iframe | ||
class="video" | ||
src="https://www.youtube.com/embed/85AnZNWixlg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The video isn’t trimmed — it’s 50 seconds long, but only the first 18 seconds are actually relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelostblom You re-uploaded the videos, right? Will you be able to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forwarded this request to the people trimming the videos for us. We can merge this PR and follow up on that separately.
@joelostblom @sandygross All comments except for the outro video has been resolved. Thank you! |
Here is the PR for module 7.
result
is not None and we can test it. However, printing the string version of the report is easier for students to interpret the results.