Merging to release-5.10: [TT-14814] fix bundle loading issue (#7436) #7452
+187
−75
probelabs / Visor: quality
failed
Oct 14, 2025 in 21m 21s
🚨 Check Failed
quality check failed because fail_if condition was met.
Details
📊 Summary
- Total Issues: 3
- Error Issues: 2
- Warning Issues: 1
🔍 Failure Condition Results
❌ Failed Conditions
- global_fail_if: Global failure condition met
⚠️ Severity: Error
🐛 Issues by Category
🧠 Logic (3)
- ❌ gateway/coprocess_bundle.go:228 - Errors from
newFile.Close()are logged but not propagated. A failure to close a file (e.g., due to a disk write error during flush) will not be reported to the caller, potentially leading to corrupted or incomplete bundle files being treated as valid. ⚠️ gateway/coprocess_bundle.go:427 - When an existing bundle fails manifest verification, the error is correctly returned, but the invalid bundle directory and its contents are left on the filesystem. This could lead to confusion or potential issues on subsequent gateway restarts if the invalid artifacts are not cleaned up.- ❌ system:0 - Global failure condition met
Generated by Visor - AI-powered code review
Annotations
Check failure on line 234 in gateway/coprocess_bundle.go
probelabs / Visor: quality
logic Issue
Errors from `newFile.Close()` are logged but not propagated. A failure to close a file (e.g., due to a disk write error during flush) will not be reported to the caller, potentially leading to corrupted or incomplete bundle files being treated as valid.
Raw output
Handle the errors from `Close()` calls explicitly and return them. This ensures that I/O failures during file closing are properly propagated and handled.
Check warning on line 433 in gateway/coprocess_bundle.go
probelabs / Visor: quality
logic Issue
When an existing bundle fails manifest verification, the error is correctly returned, but the invalid bundle directory and its contents are left on the filesystem. This could lead to confusion or potential issues on subsequent gateway restarts if the invalid artifacts are not cleaned up.
Raw output
To ensure a clean state and prevent the use of invalid artifacts, remove the bundle directory if manifest validation fails for an existing bundle. This behavior would be consistent with how newly fetched bundles are handled on verification failure.
Loading