[TT-13924]: updated go mod for kafka datasource #7058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Knock Knock! 🔍 Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR. An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️
Check out this guide to learn more about PR best-practices. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
API Changes no api changes detected |
buraksezer
approved these changes
May 15, 2025
kofoworola
force-pushed
the
fix/kafka
branch
2 times, most recently
from
792e7dd to
d078a29
Compare
|
|
/release to release-5.8 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
May 23, 2025
### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13924" title="TT-13924" target="_blank">TT-13924</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Change in behaviour of resolve for GraphQL Engine sends errors to UDG subscribers on new Kafka messages</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Code Review</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20Commercial_candidate_rel3-2025%20ORDER%20BY%20created%20DESC" title="Commercial_candidate_rel3-2025">Commercial_candidate_rel3-2025</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20Release3Candidate%20ORDER%20BY%20created%20DESC" title="Release3Candidate">Release3Candidate</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20customer_bug%20ORDER%20BY%20created%20DESC" title="customer_bug">customer_bug</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20jira_escalated%20ORDER%20BY%20created%20DESC" title="jira_escalated">jira_escalated</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> [TT-13924](https://tyktech.atlassian.net/browse/TT-13924) ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-13924]: https://tyktech.atlassian.net/browse/TT-13924?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ ### **PR Type** enhancement ___ ### **Description** - Upgraded `graphql-go-tools` dependency to latest commit - Added new indirect dependencies for supporting libraries - Updated `go.sum` to reflect new dependency versions - Ensured compatibility with Kafka datasource enhancements ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Upgrade graphql-go-tools and add indirect dependencies</code> </dd></summary> <hr> go.mod <li>Upgraded <code>github.com/TykTechnologies/graphql-go-tools</code> to a newer commit<br> <li> Added several new indirect dependencies (e.g., <code>cobra</code>, <code>viper</code>, <code>jennifer</code>)<br> <li> Updated dependency versions for improved compatibility </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7058/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+8/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>Update go.sum for new and upgraded dependencies</code> </dd></summary> <hr> go.sum <li>Added checksums for new and updated dependencies<br> <li> Reflected changes from go.mod updates<br> <li> Ensured integrity of new indirect dependencies </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7058/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+31/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details> (cherry picked from commit cc0add2)
7 tasks
|
@kofoworola Created merge PRs |
buger
added a commit
that referenced
this pull request
May 23, 2025
…ce (#7058) [TT-13924]: updated go mod for kafka datasource (#7058) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13924" title="TT-13924" target="_blank">TT-13924</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Change in behaviour of resolve for GraphQL Engine sends errors to UDG subscribers on new Kafka messages</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Code Review</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20Commercial_candidate_rel3-2025%20ORDER%20BY%20created%20DESC" title="Commercial_candidate_rel3-2025">Commercial_candidate_rel3-2025</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20Release3Candidate%20ORDER%20BY%20created%20DESC" title="Release3Candidate">Release3Candidate</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20customer_bug%20ORDER%20BY%20created%20DESC" title="customer_bug">customer_bug</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20jira_escalated%20ORDER%20BY%20created%20DESC" title="jira_escalated">jira_escalated</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- <!-- Provide a general summary of your changes in the Title above --> ## Description <!-- Describe your changes in detail --> [TT-13924](https://tyktech.atlassian.net/browse/TT-13924) ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-13924]: https://tyktech.atlassian.net/browse/TT-13924?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ ### **PR Type** enhancement ___ ### **Description** - Upgraded `graphql-go-tools` dependency to latest commit - Added new indirect dependencies for supporting libraries - Updated `go.sum` to reflect new dependency versions - Ensured compatibility with Kafka datasource enhancements ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Upgrade graphql-go-tools and add indirect dependencies</code> </dd></summary> <hr> go.mod <li>Upgraded <code>github.com/TykTechnologies/graphql-go-tools</code> to a newer commit<br> <li> Added several new indirect dependencies (e.g., <code>cobra</code>, <code>viper</code>, <code>jennifer</code>)<br> <li> Updated dependency versions for improved compatibility </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7058/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+8/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>Update go.sum for new and upgraded dependencies</code> </dd></summary> <hr> go.sum <li>Added checksums for new and updated dependencies<br> <li> Reflected changes from go.mod updates<br> <li> Ensured integrity of new indirect dependencies </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7058/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+31/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
TT-13924
Description
TT-13924
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
PR Type
enhancement
Description
Upgraded
graphql-go-toolsdependency to latest commitAdded new indirect dependencies for supporting libraries
Updated
go.sumto reflect new dependency versionsEnsured compatibility with Kafka datasource enhancements
Changes walkthrough 📝
go.mod
Upgrade graphql-go-tools and add indirect dependenciesgo.mod
github.com/TykTechnologies/graphql-go-toolsto a newer commitcobra,viper,jennifer)go.sum
Update go.sum for new and upgraded dependenciesgo.sum