-
Notifications
You must be signed in to change notification settings - Fork 104
add new section in HMM tutorial #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview the changes: https://turinglang.org/docs/pr-previews/508 |
yebai
approved these changes
Sep 25, 2024
Thanks @JasonPekos. It looks good! |
yebai
reviewed
Sep 25, 2024
penelopeysm
reviewed
Sep 28, 2024
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Thanks @JasonPekos for putting this together! I've just gone ahead and made my suggested changes directly --- and also updated a few lines so that it would be compatible with current Turing versions, so will merge now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a section to the HMMs tutorial that has a much faster and more concise version of the model (four lines!) using HiddenMarkovModels.jl.
There's a subsection after that which shows how to recover the state estimates with the Viterbi algorithm.
This closes: