Add missing tovec methods for NamedTuple and Tuple.
#939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Benchmark Report for Commit 40fba7eComputer InformationBenchmark Results |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 82.91% 82.92%
=======================================
Files 36 36
Lines 3962 3964 +2
=======================================
+ Hits 3285 3287 +2
Misses 677 677 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Penny could you give it quick look? I didn't try hard to make the test good and fit well in. So welcome to correct and also absolutely okay to fix directly. |
Pull Request Test Coverage Report for Build 15248584238Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 15248584238Details
💛 - Coveralls |
penelopeysm
approved these changes
May 27, 2025
There was a problem hiding this comment.
There are still issues with Bijectors
using Turing
@model function f(x = [1.5, 2.0])
priors ~ product_distribution((m=Normal(), s=Beta(2, 2)))
x .~ Normal(priors.m, sqrt(priors.s))
return priors
end
sample(f(), NUTS(), 1000)
#=
ERROR: MethodError: no method matching bijector(::Distributions.ProductNamedTupleDistribution{(:m, :s), Tuple{Normal{…}, Beta{…}}, Continuous, Float64})
The function `bijector` exists, but no method is defined for this combination of argument types.
Closest candidates are:
bijector(::KSOneSided)
@ Bijectors ~/.julia/packages/Bijectors/L7xKL/src/transformed_distribution.jl:125
bijector(::Product{Continuous, T, Tdists} where {T<:Distribution{Univariate, Continuous}, Tdists<:(FillArrays.Fill{T, 1})})
@ BijectorsDistributionsADExt ~/.julia/packages/Bijectors/L7xKL/ext/BijectorsDistributionsADExt.jl:28
bijector(::Product{Discrete, T, V} where {T<:Distribution{Univariate, Discrete}, V<:AbstractVector{T}})
@ Bijectors ~/.julia/packages/Bijectors/L7xKL/src/transformed_distribution.jl:79
...
=#but I think on the DynamicPPL side this looks fine.
|
I edited the first comment to not close the issue, just so that we can keep track of it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#933