-
Notifications
You must be signed in to change notification settings - Fork 35
Move bijector(dynamicpplmodel)
from Turing.jl
#920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Report for Commit 6950cecComputer Information
Benchmark Results
|
Pull Request Test Coverage Report for Build 15031798993Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 15031798993Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 15089611356Details
💛 - Coveralls |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 85.01% 85.10% +0.08%
==========================================
Files 35 36 +1
Lines 3924 3954 +30
==========================================
+ Hits 3336 3365 +29
- Misses 588 589 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Red-Portal thanks for this! I've had a look at the code itself and all seems fine.
Before merging, would you be able to:
- make a patch release in
Project.toml
- add a changelog entry in
HISTORY.md
?
Done! |
DynamicPPL.jl documentation for PR #920 is available at: |
@penelopeysm I don't have merge rights so someone will have to press a button! |
Oh, I'm sorry! I actually checked and I thought that you'd have merge rights since you're a member of the TuringLang organisation. I guess it might be because it's a merge into |
I triggered a release, so you should be able to use it in a short while. |
This moves the
bijector
specialization that extracts a bijector from a DynamicPPLModel
, which was inTuring.jl