Skip to content

Fix isnan for NamedTuple distributions #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Fix isnan for NamedTuple distributions #897

merged 2 commits into from
Apr 23, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Apr 23, 2025

Fixes #898

Not gonna bother requesting reviews, IMO this is trivial enough

@penelopeysm penelopeysm enabled auto-merge April 23, 2025 00:36
Copy link
Contributor

Benchmark Report for Commit c87637a

Computer Information

Julia Version 1.11.5
Commit 760b2e5b739 (2025-04-14 06:53 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.7 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                628.4 |                41.5 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                428.4 |                45.9 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1262.7 |                27.1 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3293.8 |                25.8 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1491.9 |                29.9 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                970.3 |                 5.3 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5608.7 |                 4.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1024.3 |                 8.9 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              63032.5 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               9159.4 |                 9.6 |
|               Dynamic |        10 |    mooncake |             typed |   true |                149.8 |                10.8 |
|              Submodel |         1 |    mooncake |             typed |   true |                 25.7 |                 8.3 |
|                   LDA |        12 | reversediff |             typed |   true |                476.5 |                 5.3 |

@coveralls
Copy link

coveralls commented Apr 23, 2025

Pull Request Test Coverage Report for Build 14607227935

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 47 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.01%) to 84.878%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
ext/DynamicPPLEnzymeCoreExt.jl 1 0.0%
ext/DynamicPPLForwardDiffExt.jl 1 63.64%
src/sampler.jl 1 89.23%
src/varnamedvector.jl 1 90.1%
src/logdensityfunction.jl 2 52.27%
src/utils.jl 2 73.7%
src/contexts.jl 3 64.62%
src/model.jl 3 84.17%
src/values_as_in_model.jl 3 59.52%
src/simple_varinfo.jl 6 75.14%
Totals Coverage Status
Change from base Build 14449056171: -0.01%
Covered Lines: 3261
Relevant Lines: 3842

💛 - Coveralls

@penelopeysm penelopeysm disabled auto-merge April 23, 2025 01:17
@penelopeysm penelopeysm merged commit cb4ea95 into main Apr 23, 2025
1 check passed
@penelopeysm penelopeysm deleted the py/isnan branch April 23, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isnan check on NamedTuples with nested vectors fails
2 participants