-
Notifications
You must be signed in to change notification settings - Fork 19
Addition of step_warmup
#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0987f5f
added step_warmup which is can be overloaded when convenient
torfjelde 30c9f12
added step_warmup to docs
torfjelde 7faa73f
Update src/interface.jl
torfjelde bd0bdc7
introduce new kwarg `num_warmup` to `sample` which uses `step_warmup`
torfjelde c620cca
updated docs
torfjelde 572a286
allow combination of discard_initial and num_warmup
torfjelde 6b842ee
added docstring for mcmcsample
torfjelde ca03832
Merge branch 'torfjelde/step-warmup' of github.com:TuringLang/Abstrac…
torfjelde 0441773
Apply suggestions from code review
torfjelde ea369ff
Apply suggestions from code review
torfjelde 8e0ca53
Update src/sample.jl
torfjelde 6877978
removed docstring and deferred description of keyword arguments to th…
torfjelde b3b3148
Merge branch 'torfjelde/step-warmup' of github.com:TuringLang/Abstrac…
torfjelde ddc5254
Update src/sample.jl
torfjelde ffbd32f
Update src/sample.jl
torfjelde 87480ff
added num_warmup to common keyword arguments docs
torfjelde 76f2f23
also allow step_warmup for the initial step
torfjelde c00d0c9
Merge branch 'torfjelde/step-warmup' of github.com:TuringLang/Abstrac…
torfjelde ef09c19
simplify logic for discarding fffinitial samples
torfjelde 49b8406
Apply suggestions from code review
torfjelde f005746
also report progress for the discarded samples
torfjelde 9dccd8a
Merge branch 'torfjelde/step-warmup' of github.com:TuringLang/Abstrac…
torfjelde ff00e6e
Apply suggestions from code review
torfjelde 7ce9f6b
move progress-report to end of for-loop for discard samples
torfjelde 3a217b2
move step_warmup to the inner while loops too
torfjelde de9bb2c
Update src/sample.jl
torfjelde 85d938f
Apply suggestions from code review
torfjelde 0a667a4
reverted to for-loop
torfjelde 91f5a10
Update src/sample.jl
torfjelde 7603171
added accidentanly removed comment
torfjelde ef68d04
Update src/sample.jl
torfjelde 25afc66
Merge branch 'master' into torfjelde/step-warmup
torfjelde 1886fa8
Merge branch 'master' into torfjelde/step-warmup
torfjelde 0ea293a
fixed formatting
torfjelde 6e8f88e
fix typo
torfjelde 44c55bb
Merge branch 'master' into torfjelde/step-warmup
torfjelde 3b4f6db
Apply suggestions from code review
torfjelde f9142a6
Added testing of warmup steps
torfjelde 295fdc1
Added checks as @devmotion requested
torfjelde e6acb1f
Removed unintended change in previous commit
torfjelde 2e9fa5c
Bumped patch version
torfjelde 366fceb
Bump minor version instead of patch version since this is a new feature
torfjelde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.