files.js -- Update with code from Files Expanded #1833
Conversation
SharkPool-SP
changed the title
|
!format |
|
Related PR: #1594 |
CubesterYT
added
pr: change existing extension
|
|
Ah, someone that actually knows what they are doing. I'm just going to close mine, since this does everything that mine would do (and better). |
|
Renamed the branch, reopen the PR from |
|
!format |
|
!format |
| * @param {Uint8Array} buffer | ||
| * @returns {string} base64 | ||
| */ | ||
| function bufferToBase64(buffer) { |
There was a problem hiding this comment.
this seems wasteful and copied from stackoverflow, is there a reason you cant use the globally exposed Base64 module
There was a problem hiding this comment.
im not certain that module can do this stuff, i cant seem to find any useful documentation on it either
| @@ -444,7 +1117,242 @@ | |||
| console.warn(`unknown mode`, args.mode); | |||
| } | |||
| } | |||
|
|
|||
| fileInfo(args) { | |||
| if (args.FORMAT === "size formatted") return FileSize; | |||
There was a problem hiding this comment.
checking again you dont cast anything in your new changes, that should be fixed
There was a problem hiding this comment.
I dont really see a need to cast this?
|
!format |
|
this must be merged first before this can be officially PR-ed: |
THIS MUST BE MERGED FIRST:
TurboWarp/scratch-gui#979
Super Mega Update to the Files Extension to port over many new features from my expansion of the extension.
This includes:
Closes:
#1603
#156
#837
Files Expanded:
https://github.com/SharkPool-SP/SharkPools-Extensions/blob/main/extension-code/Files-Expanded.js