feat(query): complete ScalarValue type support for aggregation functions #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions - Add Boolean type support for Sum/Avg (converts to 0.0/1.0) - Add Boolean type support for Min/Max (direct comparison) - Add comprehensive error handling for unsupported types: - String type: returns error for Sum/Avg operations - Vector/Vertex/Edge: returns error for all aggregation operations - Add complete NULL value handling: - ScalarValue::Null: ignored in aggregation - All None variants (Boolean(None), Int8(None), etc.): ignored - Update AggregateState structs: - Add min_bool and max_bool fields to Min/Max variants - Update constructors and finalize functions - Ensure exhaustive pattern matching for all ScalarValue variants - Remove all TODO comments related to type handling All 23 aggregate tests pass. The aggregate executor now supports complete type coverage with proper error handling and NULL safety.
- Replace boolean order comparisons with logical operations: - Min: *v < *current -> !(*v) && *current - Max: *v > *current -> *v && !(*current) - Apply cargo fmt to fix code formatting issues - All tests still pass after changes
|
@ColinLeeo 请求审查一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Type
feat: (new feature)fix: (bug fix)docs: (doc update)refactor: (refactor code)test: (test code)chore: (other updates)Scope
query: (query engine)parser: (frontend parser)planner: (frontend planner)optimizer: (query optimizer)executor: (execution engine)op: (operators)storage: (storage engine)mvcc: (multi version concurrency control)schema: (graph model and topology)tool: (tools)cli: (cli)sdk: (sdk)none: (N/A)Description
Issue:
This PR completes the ScalarValue type support for aggregation functions in the execution engine. The aggregate executor now handles all possible ScalarValue variants with proper error handling and NULL safety.
Key Changes:
Testing:
Checklist
masterbranch.