Feat/meta data v2 #990

ankitsmt211 · 2023-12-17T12:31:28Z

Adding more data from help threads to our already existing table, along with listener that updates changes done after thread creation.

Alter Help_Thread table
Update write operation to db with extra fields
Update ticket status and closedAt when thread archived/closed.

Additions:

update message count per thread
members participated per thread
routine that settles ticket status due to hiccup

Flow

Help thread is created and registered in DB
- creation timestamp, applied tags, channel id, author id, ticket status etc is registered
on change of category, tag data is updated
on archiving
- message count, participant count, closed timestamp, ticket status is updated
on thread revival and further archival
- message count, participant count, closed timestamp is updated again.
if due to bot downtime, thread ticket status is marked open in db then a routine will change that for threads that are older than 3 days (assuming no thread should be alive post 3 days)

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

application/src/main/resources/db/V14__Alter_Help_Thread_Metadata.sql

application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java

…ge update

marko-radosavljevic · 2023-12-27T01:58:17Z

Seems fine, doesn't really resolve #660 since we are not using or displaying this data. So probably a fresh issue should be created with how to move forward with interpreting and displaying this data in a meaningful and nice way, UI wise. ^^

ankitsmt211 · 2023-12-27T02:18:20Z

Seems fine, doesn't really resolve #660 since we are not using or displaying this data. So probably a fresh issue should be created with how to move forward with interpreting and displaying this data in a meaningful and nice way, UI wise. ^^

True, imma remove the referenced issue.

Zabuzard

the code itself is fine, but the system has a crucial problem. it is not resilient at all. thread status will be incorrect in case of issues:

if an update message is missed bc of error, the thread remains "open" in the DB
if the bot is offline and turned on after a few days again, threads that have been closed remain "open" in the DB

there should be some sort of routine that checks threads that are marked open but are older than three days, just to make sure the metadata remains correct

ankitsmt211 · 2024-01-03T23:37:44Z

the code itself is fine, but the system has a crucial problem. it is not resilient at all. thread status will be incorrect in case of issues:

if an update message is missed bc of error, the thread remains "open" in the DB

if the bot is offline and turned on after a few days again, threads that have been closed remain "open" in the DB

there should be some sort of routine that checks threads that are marked open but are older than three days, just to make sure the metadata remains correct

should it also update other data? like message count/participants from already closed thread? or just status?

* update constructor with HelpThreadLifecycleListener instance * using HelpThreadLifecycleListener method to clean up left over threads * increasing scope of handleArchiveStatus to package level * adding logger to MarkHelpThreadCloseInDBRoutine class

application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

...ation/src/main/java/org/togetherjava/tjbot/features/help/MarkHelpThreadCloseInDBRoutine.java

application/src/main/resources/db/V14__Alter_Help_Thread_Metadata.sql

* requested changes * update config to include tagsToIgnore * refactor tag update logic * update sql script * add tagsToIgnore list to config

ankitsmt211 · 2024-05-17T18:51:58Z

didnt we remove star imports, what's up with spotless being mad about it?

Taz03 · 2024-05-17T19:03:40Z

didnt we remove star imports, what's up with spotless being mad about it?

no, there's no config change.
Its not telling u to use star imports (that's out of the scope of spotless) its just reordering the imports

ankitsmt211 · 2024-05-18T02:27:32Z

didnt we remove star imports, what's up with spotless being mad about it?

no, there's no config change. Its not telling u to use star imports (that's out of the scope of spotless) its just reordering the imports

the problem is it's asking me to run spotless, if i do that it just turns it into a star import.

* adding data fields that are being collected in privacy policy * updating duration of data storage in privacy policy doc * HelpThreadMetadataPurger will now purge help threads data post 180 days * instead of appending new tags, only new tags are stored now

application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

...ation/src/main/java/org/togetherjava/tjbot/features/help/MarkHelpThreadCloseInDBRoutine.java

sonarqubecloud · 2024-06-02T13:47:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ankitsmt211 added 7 commits December 17, 2023 17:37

alter help_thread table to add more meta data

744d816

update write operation with extra fields

bc3fab1

listener that updates meta data based on thread status

0f5e116

fix error in log messages

ff7ec2f

method to update tagName on change in db

8508977

more suitable name for class and java doc

198df3a

change name to avoid confusion & update java doc

76b09e9

ankitsmt211 marked this pull request as ready for review December 18, 2023 10:16

ankitsmt211 requested review from a team as code owners December 18, 2023 10:16

ankitsmt211 self-assigned this Dec 18, 2023

ankitsmt211 added enhancement New feature or request priority: normal labels Dec 18, 2023

ankitsmt211 commented Dec 18, 2023

View reviewed changes

ankitsmt211 added 5 commits December 18, 2023 16:04

minor bug that would change status back to active again and log messa…

c2842cf

…ge update

more columns added for metadata

c5768c2

update listener to record added metadata columns

a1ecd95

spotless fix

0bd0c13

replacing get(0) with getFirst() for list

28c28b4

Zabuzard requested changes Jan 3, 2024

View reviewed changes

add routine to settle thread status if was left open

7708513

ankitsmt211 closed this Jan 3, 2024

ankitsmt211 reopened this Jan 3, 2024

ankitsmt211 added 4 commits January 9, 2024 11:50

resolve conflicts

3323c48

spotless fix

ab0fe61

document updated param in MarkHelpThreadCloseInDBRoutine constructor

dcf9a7a

ankitsmt211 requested a review from Zabuzard January 24, 2024 18:41

Taz03 requested changes Mar 12, 2024

View reviewed changes

ankitsmt211 added 3 commits May 16, 2024 08:52

use time of creation/modfication from thread and tags as csv

41667e3

rely on discord for getting thread status instead of DB

ca6d4d4

Merge branch 'develop' into feat/meta-data-v2

6d2848e

Taz03 requested changes May 17, 2024

View reviewed changes

application/src/main/resources/db/V14__Alter_Help_Thread_Metadata.sql Outdated Show resolved Hide resolved

changes

87461c3

* requested changes * update config to include tagsToIgnore * refactor tag update logic * update sql script * add tagsToIgnore list to config

ankitsmt211 requested a review from Taz03 May 17, 2024 18:52

ankitsmt211 added the config-changes if your PR contains any changes related to config file label May 18, 2024

ankitsmt211 added 5 commits May 18, 2024 13:11

change list

7d2256c

* adding data fields that are being collected in privacy policy * updating duration of data storage in privacy policy doc * HelpThreadMetadataPurger will now purge help threads data post 180 days * instead of appending new tags, only new tags are stored now

spotless fix

3089083

tags from config sanitized

a665aa7

requested changes

b061ae0

spotless

e302e95

Taz03 requested changes May 25, 2024

View reviewed changes

ankitsmt211 mentioned this pull request Jun 1, 2024

Collecting analytics for #active_questions #660

Open

requested changes

c745481

Taz03 reviewed Jun 1, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java Outdated Show resolved Hide resolved

...ation/src/main/java/org/togetherjava/tjbot/features/help/MarkHelpThreadCloseInDBRoutine.java Show resolved Hide resolved

ankitsmt211 added 2 commits June 1, 2024 18:38

remove unnecessary map

495e4d2

increase routine schedule to 24 hrs

b10387c

ankitsmt211 removed the config-changes if your PR contains any changes related to config file label Jun 2, 2024

Taz03 approved these changes Jun 2, 2024

View reviewed changes

ankitsmt211 merged commit 7bc47d6 into develop Jun 4, 2024
10 checks passed

ankitsmt211 deleted the feat/meta-data-v2 branch June 4, 2024 18:01

ankitsmt211 mentioned this pull request Jun 8, 2024

Release v4.13 #1129

Merged

Uh oh!

Feat/meta data v2 #990

Feat/meta data v2 #990

Uh oh!

Conversation

ankitsmt211 commented Dec 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marko-radosavljevic commented Dec 27, 2023

Uh oh!

ankitsmt211 commented Dec 27, 2023

Uh oh!

Zabuzard left a comment

Choose a reason for hiding this comment

Uh oh!

ankitsmt211 commented Jan 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ankitsmt211 commented May 17, 2024

Uh oh!

Taz03 commented May 17, 2024

Uh oh!

ankitsmt211 commented May 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 2, 2024

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

ankitsmt211 commented Dec 17, 2023 •

edited

Loading