-
-
Notifications
You must be signed in to change notification settings - Fork 91
fix: Handle empty message content for suggestion threads #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
billpapat
wants to merge
7
commits into
Together-Java:develop
Choose a base branch
from
billpapat:fix/image-suggestion
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−9
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
482eef7
fix: handle empty message content for thread titles
billpapat 629ac8c
style: apply gradle task `spotlessApply`
billpapat 08da794
fix: thread titles #1265
billpapat 6b6b883
docs(ThreadTitle): add JavaDocs and rename param
billpapat 71112b0
Changes as per requested by Zabuzard
billpapat d2892b3
Changes as per requested by Zabuzard
billpapat 006a3ee
Changes as per requested by Taz03
billpapat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
application/src/main/java/org/togetherjava/tjbot/features/basic/ThreadTitle.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
package org.togetherjava.tjbot.features.basic; | ||
|
||
/** | ||
* Represents a thread title, enforcing a maximum length of 60 characters. If an initial title | ||
* exceeds this limit, it's truncated at the last word boundary before or at the 60-character mark | ||
* to prevent cutting words mid-sentence. If no space is found, it truncates at 60 characters. | ||
* Provides a static factory method `withFallback` to create a ThreadTitle, using a fallback title | ||
* if the primary title is empty. | ||
*/ | ||
public record ThreadTitle(String value) { | ||
christolis marked this conversation as resolved.
Show resolved
Hide resolved
Zabuzard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
private static final int TITLE_MAX_LENGTH = 60; | ||
|
||
public ThreadTitle(String value) { | ||
String threadTitle; | ||
if (value.length() >= TITLE_MAX_LENGTH) { | ||
int lastWordEnd = value.lastIndexOf(' ', TITLE_MAX_LENGTH); | ||
|
||
if (lastWordEnd == -1) { | ||
lastWordEnd = TITLE_MAX_LENGTH; | ||
} | ||
|
||
threadTitle = value.substring(0, lastWordEnd); | ||
} else { | ||
threadTitle = value; | ||
} | ||
|
||
this.value = threadTitle; | ||
} | ||
|
||
public static ThreadTitle withFallback(String primary, String fallback) { | ||
if (!primary.isEmpty()) { | ||
return new ThreadTitle(primary); | ||
} else { | ||
return new ThreadTitle(fallback); | ||
} | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return value; | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.