Skip to content

Improved Scam detector logic #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

Zabuzard
Copy link
Member

Improved the automatic scam detector logic. Added more real scam examples (DONT CLICK on these links, they are dangerous).
Further, added dollar-sign detection as extra sign of scam. Also added @here to the pingsEveryone logic.

Logic Review

Previous had a shortcut for:

results.pingsEveryone && results.containsSuspiciousKeyword && results.hasUrl

and otherwise:

results.containsSuspiciousKeyword && results.hasSuspiciousUrl

The new logic relaxed the shortcut heavily (since an everyone-ping is a clear sign for scam):

results.pingsEveryone && (results.containsSuspiciousKeyword || results.hasUrl || results.containsDollarSign)

and otherwise requires 2 out of the following 3 signs:

results.containsSuspiciousKeyword, results.hasSuspiciousUrl, results.containsDollarSign

Config

When releasing this, make sure to apply the changed config as well. scamBlocker received a lot of new keywords.

* more real scam
* improved logic
* dollar sign detection
@Zabuzard Zabuzard added the enhancement New feature or request label Feb 18, 2025
@Zabuzard Zabuzard self-assigned this Feb 18, 2025
@Zabuzard Zabuzard requested a review from a team as a code owner February 18, 2025 08:38
Copy link

@Zabuzard Zabuzard merged commit d357b6e into develop Feb 18, 2025
11 checks passed
@Zabuzard Zabuzard deleted the feature/scam_detector_improvements branch February 18, 2025 08:51
@Zabuzard Zabuzard added the config-changes if your PR contains any changes related to config file label Feb 18, 2025
@Zabuzard Zabuzard mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes if your PR contains any changes related to config file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants