Skip to content

Bump Java Version to 24 #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 1, 2025
Merged

Bump Java Version to 24 #1071

merged 17 commits into from
Jul 1, 2025

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Mar 22, 2024 •
edited by Zabuzard
Loading

Updates Java from 21 to 24, Gradle from 8.5 to 8.14.2 and also other stuff while at it:

  • com.google.cloud.tools.jib: 3.4.0 -> 3.4.5
  • com.diffplug.spotless: 7.0.3 -> 7.0.4
  • name.remal.sonarlint: 4.2.2 -> 5.1.10
  • jooqVersion: 3.20.4 -> 3.20.5
  • jacksonVersion: 2.19.0 -> 2.19.1
  • chatGPTVersion: 0.18.0 -> 0.18.2

Further:

  • Used _ instead of any or ignored
  • removed two unused variables
  • cat
    image

@Taz03 Taz03 requested a review from a team as a code owner March 22, 2024 18:40
@Taz03 Taz03 self-assigned this Mar 22, 2024
@Taz03 Taz03 added enhancement New feature or request priority: normal labels Mar 22, 2024
@SquidXTV
Copy link
Member

The workflows cannot be on Java 22, because gradle itself doesn't support Java 22 it only supports running code on Java 22.

This is from gradle release notes:- image

but compiling to java 22 works fine right? just not running the daemon with java 22, right?

@Taz03
Copy link
Member Author

Taz03 commented Mar 22, 2024

@SquidXTV Yes, compiling works fine. That's why the tests pass

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Zabuzard
Zabuzard previously requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked at least until Adoptium offers Java 22 on the main page (i.e. after official release).

@Taz03 Taz03 marked this pull request as draft March 25, 2024 08:16
@SquidXTV
Copy link
Member

Blocked at least until Adoptium offers Java 22 on the main page (i.e. after official release).

It does right?
https://adoptium.net/temurin/releases/?version=22

@SimonVerhoeven
Copy link
Contributor

It would be nice to see this one merged.

@Taz03 Taz03 removed their assignment Apr 14, 2024
@Zabuzard Zabuzard dismissed their stale review May 23, 2024 08:41

blocking issue has been resolved apparently

@Taz03 Taz03 force-pushed the java-22 branch 5 times, most recently from ef468ff to 2f86aae Compare May 30, 2024 06:51
@SquidXTV
Copy link
Member

SquidXTV commented Jun 1, 2024

gradle 8.8 released so this can be finished

@Taz03
Copy link
Member Author

Taz03 commented Jun 1, 2024

blocked by #1123

@Taz03
Copy link
Member Author

Taz03 commented Jun 6, 2024

Issue related to sonarlint failing https://community.sonarsource.com/t/java-21-unamed-pattern-error/109839

@SquidXTV
Copy link
Member

SquidXTV commented Jun 7, 2024

Issue related to sonarlint failing https://community.sonarsource.com/t/java-21-unamed-pattern-error/109839

It is talking about preview features and java 21. How is this related?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
19 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Zabuzard Zabuzard added the dependencies Pull requests that update a dependency file label Jul 1, 2025
@Zabuzard Zabuzard changed the title upgrade to java 22 Bump Java Version to 24 Jul 1, 2025
@Zabuzard Zabuzard self-assigned this Jul 1, 2025
@Zabuzard Zabuzard removed the enhancement New feature or request label Jul 1, 2025
@Zabuzard Zabuzard marked this pull request as ready for review July 1, 2025 09:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Zabuzard Zabuzard merged commit f206bd4 into develop Jul 1, 2025
11 checks passed
@Zabuzard Zabuzard deleted the java-22 branch July 1, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

Assignees

@Zabuzard Zabuzard

Labels
dependencies Pull requests that update a dependency file priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Taz03 @SquidXTV @SimonVerhoeven @Zabuzard