Skip to content

added additional fields #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

phacic
Copy link

@phacic phacic commented Aug 7, 2022

  • added first_name and last_name fields
  • added username field with validation
  • added date_joined field

@Tobi-De
Copy link
Owner

Tobi-De commented Aug 7, 2022

Hi @phacic, thanks for taking the time to do this and for submitting a pull request but as far as this package is concerned I'd like to not stray too far from the work of the official fastapi-users adapters.

I think that the management of users personal info should be done on the application code side of things according to each one needs. I for example since I've watched this I avoid using the first_name and last_name fields. But if this is something that you implement frequently, you can create a pypi packapge from a fork and use it directly.

Fastapi-users allows the developer to manage the specific information of their users as they wish through customization. I think that these fields do not belong in the database adapter.

@phacic
Copy link
Author

phacic commented Aug 7, 2022

hello, @Tobi-De I completely understand your point but I can see some people benefiting from these fields and since they are optional and overridable they won't have any adverse effect I can think of.

Also, can we open a PR with Fastapi-users and add your work to the official repo

@caniko
Copy link

caniko commented Sep 2, 2022

hello, @Tobi-De I completely understand your point but I can see some people benefiting from these fields and since they are optional and overridable they won't have any adverse effect I can think of.

Also, can we open a PR with Fastapi-users and add your work to the official repo

The reason this repo was created was because tortoise-orm support was dropped, the industry is not ready to move on from sqlalchemy sadly.

The maintainer of the project made the hard decision to drop support because almost nobody used tortoise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants