Separate chunker from batcher #625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chunker was part of the batcher and responsible for transforming input data into the batcher's chain format. Hence, the batcher needed to be aware of its input types, although it would not otherwise use this information. With this change, the chunker is separate of the batcher. This simplifies the logic within the chunker slightly, but most importantly moves the responsibility to form chunks to whoever holds the batcher. In Differential, this is `arrange_core`. It now learns about an input container type and a chunker and uses the chunker to convert input data to chunks of sorted and consolidated data. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chunker was part of the batcher and responsible for transforming input data into the batcher's chain format. Hence, the batcher needed to be aware of its input types, although it would not otherwise use this information.
With this change, the chunker is separate of the batcher. This simplifies the logic within the chunker slightly, but most importantly moves the responsibility to form chunks to whoever holds the batcher. In Differential, this is
arrange_core. It now learns about an input container type and a chunker and uses the chunker to convert input data to chunks of sorted and consolidated data.