Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

chore: consider genericArgs contents in TypeHint equals and hashCode #83

Merged
merged 2 commits into from
Jun 18, 2024
Merged

chore: consider genericArgs contents in TypeHint equals and hashCode #83

merged 2 commits into from
Jun 18, 2024

Conversation

Christopher-Chianelli
Copy link
Collaborator

Although we don't use TypeHint in maps nor sets and don't currently check them for equality, we might do it later.

@Christopher-Chianelli
chore: consider genericArgs contents in TypeHint equals and hashCode
64342ac 
Although we don't use TypeHint in maps nor sets and don't
currently check them for equality, we might do it later.
triceo
triceo approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For records, this is the accepted practice. (Something that the JDK guys probably should have thought about.)

LGTM, maybe we change toString() too? Otherwise the array will not be printed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

@Christopher-Chianelli Christopher-Chianelli merged commit b8f0cb3 into TimefoldAI:main Jun 18, 2024
4 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christopher-Chianelli @triceo