fix: Use 4 for parallel_solver_count

Maybe finally a fix for flakiness?

Author: Christopher-Chianelli

tests/test_solver_manager.py

@@ -6,7 +6,6 @@
 import pytest
 from dataclasses import dataclass, field
 from typing import Annotated, List
-from copy import deepcopy
 
 
 def test_solve():
@@ -83,8 +82,6 @@ def do_change(self, solution: Solution, problem_change_director: ProblemChangeDi
     )
     problem: Solution = Solution([Entity('A'), Entity('B'), Entity('C')], [Value(1), Value(2), Value(3)],
                                  SimpleScore.ONE)
-    impossible_problem: Solution = Solution([Entity('A')], [Value(1), Value(2), Value(3)],
-                                            SimpleScore.ONE)
 
     def assert_solver_run(solver_manager, solver_job):
         assert solver_manager.get_solver_status(1) != SolverStatus.NOT_SOLVING
@@ -113,25 +110,21 @@ def assert_problem_change_solver_run(solver_manager, solver_job):
     for solver_manager in (
         SolverManager.create(solver_config),
         SolverManager.create(SolverFactory.create(solver_config)),
-        SolverManager.create(solver_config, SolverManagerConfig(parallel_solver_count=1)),
+        SolverManager.create(solver_config, SolverManagerConfig(parallel_solver_count=4)),
         SolverManager.create(SolverFactory.create(solver_config), SolverManagerConfig(parallel_solver_count='AUTO'))
     ):
         with solver_manager:
             lock.acquire()
-            solver_job = solver_manager.solve(1, deepcopy(problem))
+            solver_job = solver_manager.solve(1, problem)
             assert_solver_run(solver_manager, solver_job)
 
             lock.acquire()
-            solver_job = solver_manager.solve(1, deepcopy(impossible_problem))
+            solver_job = solver_manager.solve(1, problem)
             assert_problem_change_solver_run(solver_manager, solver_job)
 
             def get_problem(problem_id):
                 assert problem_id == 1
-                return deepcopy(problem)
-
-            def get_impossible_problem(problem_id):
-                assert problem_id == 1
-                return deepcopy(impossible_problem)
+                return problem
 
             lock.acquire()
             solver_job = (solver_manager.solve_builder()
@@ -142,7 +135,7 @@ def get_impossible_problem(problem_id):
             lock.acquire()
             solver_job = (solver_manager.solve_builder()
                           .with_problem_id(1)
-                          .with_problem_finder(get_impossible_problem)).run()
+                          .with_problem_finder(get_problem)).run()
             assert_problem_change_solver_run(solver_manager, solver_job)
 
             solution_list = []
@@ -166,7 +159,7 @@ def on_best_solution_changed(solution):
             lock.acquire()
             solver_job = (solver_manager.solve_builder()
                           .with_problem_id(1)
-                          .with_problem_finder(get_impossible_problem)
+                          .with_problem_finder(get_problem)
                           .with_best_solution_consumer(on_best_solution_changed)
                           ).run()
             assert_problem_change_solver_run(solver_manager, solver_job)
@@ -192,7 +185,7 @@ def on_best_solution_changed(solution):
             lock.acquire()
             solver_job = (solver_manager.solve_builder()
                           .with_problem_id(1)
-                          .with_problem_finder(get_impossible_problem)
+                          .with_problem_finder(get_problem)
                           .with_best_solution_consumer(on_best_solution_changed)
                           .with_final_best_solution_consumer(on_best_solution_changed)
                           ).run()
@@ -260,7 +253,7 @@ def my_exception_handler(problem_id, exception):
         try:
             (solver_manager.solve_builder()
              .with_problem_id(1)
-             .with_problem(deepcopy(problem))
+             .with_problem(problem)
              .with_exception_handler(my_exception_handler)
              .run().get_final_best_solution())
         except:
@@ -275,7 +268,7 @@ def my_exception_handler(problem_id, exception):
         try:
             (solver_manager.solve_builder()
              .with_problem_id(1)
-             .with_problem(deepcopy(problem))
+             .with_problem(problem)
              .with_best_solution_consumer(lambda solution: None)
              .with_exception_handler(my_exception_handler)
              .run().get_final_best_solution())