Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

Commit 293d284

Browse files
fix: Use an impossible to solve initial problem
- Might fix the flakiness
1 parent ea54d8f commit 293d284

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

tests/test_solver_manager.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ def do_change(self, solution: Solution, problem_change_director: ProblemChangeDi
8383
)
8484
problem: Solution = Solution([Entity('A'), Entity('B'), Entity('C')], [Value(1), Value(2), Value(3)],
8585
SimpleScore.ONE)
86+
impossible_problem: Solution = Solution([Entity('A')], [Value(1), Value(2), Value(3)],
87+
SimpleScore.ONE)
8688

8789
def assert_solver_run(solver_manager, solver_job):
8890
assert solver_manager.get_solver_status(1) != SolverStatus.NOT_SOLVING
@@ -120,13 +122,17 @@ def assert_problem_change_solver_run(solver_manager, solver_job):
120122
assert_solver_run(solver_manager, solver_job)
121123

122124
lock.acquire()
123-
solver_job = solver_manager.solve(1, deepcopy(problem))
125+
solver_job = solver_manager.solve(1, deepcopy(impossible_problem))
124126
assert_problem_change_solver_run(solver_manager, solver_job)
125127

126128
def get_problem(problem_id):
127129
assert problem_id == 1
128130
return deepcopy(problem)
129131

132+
def get_impossible_problem(problem_id):
133+
assert problem_id == 1
134+
return deepcopy(impossible_problem)
135+
130136
lock.acquire()
131137
solver_job = (solver_manager.solve_builder()
132138
.with_problem_id(1)
@@ -136,7 +142,7 @@ def get_problem(problem_id):
136142
lock.acquire()
137143
solver_job = (solver_manager.solve_builder()
138144
.with_problem_id(1)
139-
.with_problem_finder(get_problem)).run()
145+
.with_problem_finder(get_impossible_problem)).run()
140146
assert_problem_change_solver_run(solver_manager, solver_job)
141147

142148
solution_list = []
@@ -160,7 +166,7 @@ def on_best_solution_changed(solution):
160166
lock.acquire()
161167
solver_job = (solver_manager.solve_builder()
162168
.with_problem_id(1)
163-
.with_problem_finder(get_problem)
169+
.with_problem_finder(get_impossible_problem)
164170
.with_best_solution_consumer(on_best_solution_changed)
165171
).run()
166172
assert_problem_change_solver_run(solver_manager, solver_job)
@@ -186,7 +192,7 @@ def on_best_solution_changed(solution):
186192
lock.acquire()
187193
solver_job = (solver_manager.solve_builder()
188194
.with_problem_id(1)
189-
.with_problem_finder(get_problem)
195+
.with_problem_finder(get_impossible_problem)
190196
.with_best_solution_consumer(on_best_solution_changed)
191197
.with_final_best_solution_consumer(on_best_solution_changed)
192198
).run()

0 commit comments

Comments
 (0)