Simplify blosc build configuration by turning it into an object library #5507
+16
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external
blosc
library is used in the byte shuffle filter. Our build system contorted itself a bit to compile this intoTILEDB_CORE_OBJECTS
as well as the unit test. As this pull request shows there is a much simpler path.While I no longer have need of the reason I implemented this, it is nonetheless a simplification of the build process, so I figured I'd post a PR for it.
TYPE: NO_HISTORY
DESC: Simplify blosc build