Skip to content

Bump version, add standalone publish.yml #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2025
Merged

Bump version, add standalone publish.yml #39

merged 4 commits into from
May 28, 2025

Conversation

ryan-williams
Copy link
Contributor

@ryan-williams ryan-williams commented May 23, 2025 •
edited
Loading

  • Bump version to 1.0.0-SNAPSHOT
  • Add publish.yml (workflow_{call,dispatch}-able), wrapping upload_to_maven.sh
  • Some GHA version bumps
    • Updated CI JVM version from 11 to 17.
    • From Java ≥16, we get this error: 
      java.lang.RuntimeException: Failed to initialize MemoryUtil. You must start Java with `--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` (See Arrow docs)
      unless we add the --add-opens flag it asks for (cf. Arrow docs, also snowflake-jdbc#589 / snowpark-java-scala#82)
  • upload_to_maven.sh: verify Git tag matches $PROJECT_VERSION before releasing non-SNAPSHOT

@ryan-williams ryan-williams force-pushed the rw/gha branch 6 times, most recently from c1f3015 to d411748 Compare May 27, 2025 13:46
@ryan-williams ryan-williams requested review from tdbbyd and ihnorton May 27, 2025 13:57
tdbbyd
tdbbyd approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@tdbbyd tdbbyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ryan-williams ryan-williams merged commit 00499f9 into master May 28, 2025
2 checks passed
@ryan-williams ryan-williams mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdbbyd tdbbyd tdbbyd approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-williams @tdbbyd