Skip to content

[QoL] Add resource allocation warnings and enhanced system detection #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+69 −42
Open

[QoL] Add resource allocation warnings and enhanced system detection #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc18e86
[QoL] Add resource allocation warnings and enhanced system detection
Oct 10, 2025
5d3b04e
Use x-input components with RegEx parsing per maintainer feedback
Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 69 additions & 42 deletions src/renderer/views/Config.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,56 +5,66 @@
<div class="flex flex-col gap-4">
<!-- RAM Allocation -->
<x-card
class="flex flex-row justify-between items-center p-2 py-3 my-0 w-full backdrop-blur-xl backdrop-brightness-150 bg-neutral-800/20">
<div>
<div class="flex flex-row gap-2 items-center mb-2">
<Icon class="inline-flex text-violet-400 size-8" icon="game-icons:ram"></Icon>
<h1 class="my-0 text-lg font-semibold">
RAM Allocation
</h1>
class="flex flex-col p-2 py-3 my-0 w-full backdrop-blur-xl backdrop-brightness-150 bg-neutral-800/20">
<div class="flex flex-row justify-between items-center">
<div>
<div class="flex flex-row gap-2 items-center mb-2">
<Icon class="inline-flex text-violet-400 size-8" icon="game-icons:ram"></Icon>
<h1 class="my-0 text-lg font-semibold">
RAM Allocation
</h1>
</div>
<p class="text-neutral-400 text-[0.9rem] !pt-0 !mt-0">
How many gigabytes of RAM are allocated to the Windows virtual machine
</p>
</div>
<div class="flex flex-row gap-2 justify-center items-center">
<x-input
class="max-w-16 text-right text-[1.1rem]"
min="4"
:max="maxRamGB"
:value="ramGB"
@input="(e: any) => ramGB = Number(/^\d+$/.exec(e.target.value)![0] || 4)"
required
></x-input>
<p class="text-neutral-100">GB</p>
</div>
<p class="text-neutral-400 text-[0.9rem] !pt-0 !mt-0">
How many gigabytes of RAM are allocated to the Windows virtual machine
</p>
</div>
<div class="flex flex-row gap-2 justify-center items-center">
<x-input
class="max-w-16 text-right text-[1.1rem]"
min="4"
:max="maxRamGB"
:value="ramGB"
@input="(e: any) => ramGB = Number(/^\d+$/.exec(e.target.value)![0] || 4)"
required
></x-input>
<p class="text-neutral-100">GB</p>
</div>
<p v-if="ramWarning" class="text-yellow-400 text-xs mt-2 mb-0">
{{ ramWarning }}
</p>
</x-card>

<!-- CPU Cores -->
<x-card
class="flex flex-row justify-between items-center p-2 py-3 my-0 w-full backdrop-blur-xl backdrop-brightness-150 bg-neutral-800/20">
<div>
<div class="flex flex-row gap-2 items-center mb-2">
<Icon class="inline-flex text-violet-400 size-8" icon="solar:cpu-bold"></Icon>
<h1 class="my-0 text-lg font-semibold">
CPU Cores
</h1>
class="flex flex-col p-2 py-3 my-0 w-full backdrop-blur-xl backdrop-brightness-150 bg-neutral-800/20">
<div class="flex flex-row justify-between items-center">
<div>
<div class="flex flex-row gap-2 items-center mb-2">
<Icon class="inline-flex text-violet-400 size-8" icon="solar:cpu-bold"></Icon>
<h1 class="my-0 text-lg font-semibold">
CPU Cores
</h1>
</div>
<p class="text-neutral-400 text-[0.9rem] !pt-0 !mt-0">
How many CPU Cores are allocated to the Windows virtual machine
</p>
</div>
<div class="flex flex-row gap-2 justify-center items-center">
<x-input
class="max-w-16 text-right text-[1.1rem]"
min="2"
:max="maxNumCores"
:value="numCores"
@input="(e: any) => numCores = Number(/^\d+$/.exec(e.target.value)![0] || 4)"
required
></x-input>
<p class="text-neutral-100">Cores</p>
</div>
<p class="text-neutral-400 text-[0.9rem] !pt-0 !mt-0">
How many CPU Cores are allocated to the Windows virtual machine
</p>
</div>
<div class="flex flex-row gap-2 justify-center items-center">
<x-input
class="max-w-16 text-right text-[1.1rem]"
min="2"
:max="maxNumCores"
:value="numCores"
@input="(e: any) => numCores = Number(/^\d+$/.exec(e.target.value)![0] || 4)"
required
></x-input>
<p class="text-neutral-100">Cores</p>
</div>
<p v-if="cpuWarning" class="text-yellow-400 text-xs mt-2 mb-0">
{{ cpuWarning }}
</p>
</x-card>

<!-- Shared Home Folder -->
Expand Down Expand Up @@ -538,6 +548,23 @@ function updateApplicationScale(value: string | number) {
origApplicationScale.value = clamped;
}

// Computed properties for resource warnings
const ramWarning = computed(() => {
const percentage = (ramGB.value / maxRamGB.value) * 100;
if (percentage > 40) {
return `⚠️ Using ${percentage.toFixed(0)}% of total RAM - high allocation may impact host performance`;
}
return null;
});

const cpuWarning = computed(() => {
const percentage = (numCores.value / maxNumCores.value) * 100;
if (percentage > 50) {
return `⚠️ Using ${percentage.toFixed(0)}% of total CPU cores - high allocation may impact host performance`;
}
return null;
});

/**
* Assigns the initial values from the Docker Compose file to the reactive refs
* so we can display them and track when a change has been made
Expand Down