-
Notifications
You must be signed in to change notification settings - Fork 18
🌸 2025 Spring Cleaning #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vendor directory is no longer included in source control, as it's not necessary for reproducible builds and significantly increases the size of the repository. Removing vendored code also makes the repo easier to navigate, reduces noise in code reviews, and improves IDE performance.
d784908
to
a6fb6fe
Compare
2ff503c
to
06c5a69
Compare
Ubuntu 20.04 runner is retired: * Switch build-test-publish to Ubuntu 22.04 (jammy) as it is supported by BeeGFS 7.3 and 7.4. * Switch other workflows to use ubuntu-latest.
Switch from using the DCO to requiring contributors to sign the new ThinkParQ CLA.
apt-get update was failing inside Minikube due to expired GPG keys from unused third-party repositories (kubic/libcontainers). These repos are not needed for testing, so we now remove all third-party repos before adding the BeeGFS APT repos.
2172639
to
3e4bf31
Compare
philippfalk
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. See my two small questions.
I like that we are dropping the vendoring, which removes a lot of code from the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/cd
Additions or improvements to CI/CD workflows
dependencies
Updates to dependency versions
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes and modernizes the project setup and CI workflows to align with other ThinkParQ owned Go projects.
✨ Improvements include:
📚 Dependency Updates: