Skip to content

🌸 2025 Spring Cleaning #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 22, 2025
Merged

Conversation

iamjoemccormick
Copy link
Member

@iamjoemccormick iamjoemccormick commented Apr 21, 2025

This PR standardizes and modernizes the project setup and CI workflows to align with other ThinkParQ owned Go projects.

✨ Improvements include:

  • 📦 Removed vendored dependencies to reduce repo size and improve dev experience
  • 🧰 Rework how CI determines the version of Go and bump runners to at least Ubuntu 22.04 (jammy).
  • 🧾 Updated contributing process, switching from the DCO to the new ThinkParQ CLA
  • 🔖 Updated supported BeeGFS and Kubernetes versions
  • 🛠️ Fixed CI errors caused by expired, unused APT repositories in Minikube

📚 Dependency Updates:

  • ⬆️ Updated Go to 1.23.8 and bumped golang.org/x/* modules to address Dependabot alerts.
  • 🧪 Bumped test dependencies, including k8s.io/*, Ginkgo, and Gomega to address Dependabot alerts.

The vendor directory is no longer included in source control, as it's not necessary for reproducible builds and significantly increases the size of the repository.

Removing vendored code also makes the repo easier to navigate, reduces noise in code reviews, and improves IDE performance.
@iamjoemccormick iamjoemccormick force-pushed the iamjoe/chore/go-standardization branch from d784908 to a6fb6fe Compare April 21, 2025 19:22
@iamjoemccormick iamjoemccormick self-assigned this Apr 21, 2025
@iamjoemccormick iamjoemccormick added documentation Improvements or additions to documentation dependencies Updates to dependency versions ci/cd Additions or improvements to CI/CD workflows labels Apr 21, 2025
@iamjoemccormick iamjoemccormick force-pushed the iamjoe/chore/go-standardization branch 4 times, most recently from 2ff503c to 06c5a69 Compare April 21, 2025 21:35
Ubuntu 20.04 runner is retired:

* Switch build-test-publish to Ubuntu 22.04 (jammy) as it is supported by BeeGFS 7.3 and 7.4.
* Switch other workflows to use ubuntu-latest.
Switch from using the DCO to requiring contributors to sign the new ThinkParQ CLA.
apt-get update was failing inside Minikube due to expired GPG keys from unused third-party repositories (kubic/libcontainers).

These repos are not needed for testing, so we now remove all third-party repos before adding the BeeGFS APT repos.
@iamjoemccormick iamjoemccormick force-pushed the iamjoe/chore/go-standardization branch from 2172639 to 3e4bf31 Compare April 21, 2025 22:46
@iamjoemccormick iamjoemccormick changed the title Project standardization and dependency updates 🌸 2025 Spring Cleaning Apr 21, 2025
Copy link
Member

@philippfalk philippfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. See my two small questions.

I like that we are dropping the vendoring, which removes a lot of code from the repo.

@iamjoemccormick iamjoemccormick merged commit 3015e33 into master Apr 22, 2025
13 checks passed
@iamjoemccormick iamjoemccormick deleted the iamjoe/chore/go-standardization branch April 22, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Additions or improvements to CI/CD workflows dependencies Updates to dependency versions documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants