Skip to content

[GEN] Backport some debug features from Zero Hour #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[GEN] Backport some debug features from Zero Hour #775

merged 1 commit into from
Apr 29, 2025

Conversation

tomsons26
Copy link

@tomsons26 tomsons26 commented Apr 28, 2025 •
edited by xezon
Loading

This change backports the following debug features from Zero Hour:

  • DebugSupplyCenterPlacement
  • ExtraLogging
  • ShowAudioLocations

The following Keyboard toggles are not added because they would technically break debug replays:

  • MSG_META_DEBUG_SHOW_AUDIO_LOCATIONS
  • MSG_META_DEMO_TOGGLE_SUPPLY_CENTER_PLACEMENT

@tomsons26 tomsons26 force-pushed the extradbg branch 2 times, most recently from 435da5b to 4a1c620 Compare April 28, 2025 13:02
@tomsons26 tomsons26 marked this pull request as ready for review April 28, 2025 13:15
@xezon
Copy link

xezon commented Apr 28, 2025

This change needs update.

@xezon
Copy link

xezon commented Apr 29, 2025

Rebased on latest.

@xezon xezon changed the title [GEN] Backports some debug features from ZH [GEN] Backport some debug features from Zero Hour Apr 29, 2025
@xezon xezon added this to the Code foundation build up milestone Apr 29, 2025
@xezon xezon added Generals Related Generals only Debug Is mostly debug functionality Unify Unifies code between Generals and Zero Hour labels Apr 29, 2025
xezon
xezon approved these changes Apr 29, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xezon xezon merged commit 7ce6184 into TheSuperHackers:main Apr 29, 2025
13 checks passed
@tomsons26 tomsons26 deleted the extradbg branch May 1, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Debug Is mostly debug functionality Generals Related Generals only Unify Unifies code between Generals and Zero Hour
Projects
None yet
Milestone
Code foundation build up
Development

Successfully merging this pull request may close these issues.
2 participants
@tomsons26 @xezon