Skip to content

[CORE] Build non-vcpkg builds with zlib-1.1.4 again #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

xezon
Copy link

@xezon xezon commented Apr 26, 2025

Prior change #605 removed zlib-1.1.4 from non-vcpkg builds. This change recovers zlib-1.1.4 for non-vcpkg builds. The RTS_HAS_ZLIB macro was obsoleted and removed.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Apr 26, 2025
@xezon xezon requested a review from OmniBlade April 26, 2025 19:37
Copy link

@OmniBlade OmniBlade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest making either just the compilation or even the download of the old zlib conditional on if version of it isn't already found?

@xezon xezon force-pushed the xezon/restore-pristine-zlib branch from 9867080 to c3fa346 Compare April 29, 2025 18:15
@xezon xezon requested a review from OmniBlade April 29, 2025 21:29
@xezon xezon added this to the Code foundation build up milestone May 1, 2025
@xezon xezon merged commit 70e9eba into TheSuperHackers:main May 1, 2025
18 checks passed
@xezon xezon deleted the xezon/restore-pristine-zlib branch May 1, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Anything related to building, compiling Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants