Skip to content

[BFME][ZH] Validate map chunk versions in debug #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

feliwir
Copy link

@feliwir feliwir commented Apr 21, 2025

Findings so far for BFME maps:

  • HeightMap version increment from 4 to 5:
    • Version 5: Elevations are 16-bit (instead of 8-bit)
    • Version 6: There is a HeightMap border (This is post BFME, see OpenSage for reference)

@feliwir feliwir added Debug Is mostly debug functionality ZeroHour Relates to Zero Hour BFME Relates to Battle For Middle-Earth labels Apr 21, 2025
@xezon
Copy link

xezon commented Apr 22, 2025

Let us sort the [ZH][BFME] tags alphabetically. On second thought, I think this should not have BFME tag. It only touches Zero Hour.

Does Generals use the same chunk versions? If yes, replicate the same versions, otherwise, adjust versions for Generals.

@feliwir feliwir changed the title [ZH][BFME] Validate map chunk versions in debug [BFME][ZH] Validate map chunk versions in debug Apr 22, 2025
@feliwir
Copy link
Author

feliwir commented Apr 22, 2025

Let us sort the [ZH][BFME] tags alphabetically. On second thought, I think this should not have BFME tag. It only touches Zero Hour.

Does Generals use the same chunk versions? If yes, replicate the same versions, otherwise, adjust versions for Generals.

I'd need to check the general chunk versions, but i assumed WorldBuilder will get moved to Core soonish? The idea behind the BFME tag was, that you get a real error now when loading BFME maps

@xezon
Copy link

xezon commented Apr 23, 2025

If there is a version diff between Generals and Zero Hour, then we need to know before merging the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFME Relates to Battle For Middle-Earth Debug Is mostly debug functionality ZeroHour Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants