Skip to content

fix: Replace wcsncpy with wcslcpy for robustness #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

fix: Replace wcsncpy with wcslcpy for robustness #1676

merged 3 commits into from
Oct 16, 2025
+46 −94

Conversation

Skyaero42
Copy link

@Skyaero42 Skyaero42 commented Oct 7, 2025 •
edited
Loading

This change replaces wstrncpy with wstrlcpy for robustness

TODO

  • Replicate in Generals

@Skyaero42 Skyaero42 added this to the Code foundation build up milestone Oct 7, 2025
@Skyaero42 Skyaero42 self-assigned this Oct 7, 2025
@Skyaero42 Skyaero42 added the Stability Concerns stability of the runtime label Oct 7, 2025
Skyaero42
Skyaero42 commented Oct 7, 2025
View reviewed changes
@Skyaero42 Skyaero42 mentioned this pull request Oct 7, 2025
Open
8 tasks
Mauller
Mauller approved these changes Oct 10, 2025
View reviewed changes
Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Oct 12, 2025
@xezon xezon changed the title fix: replace wstrncpy with wstrlcpy for robustness fix: Replace wstrncpy with wstrlcpy for robustness Oct 12, 2025
xezon
xezon reviewed Oct 12, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is at least 1 error.

Might want to think about using ARRAY_SIZE more for robustness, maybe in a follow up change if better suited.

@xezon xezon changed the title fix: Replace wstrncpy with wstrlcpy for robustness fix: Replace wcsncpy with wcslcpy for robustness Oct 15, 2025
@Skyaero42
Copy link
Author

Changed to ARRAY_SIZE()

@xezon
Copy link

xezon commented Oct 15, 2025

Needs replicating.

@Skyaero42
Copy link
Author

Replicated in Generals

@xezon xezon merged commit 3b78b63 into TheSuperHackers:main Oct 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

@Mauller Mauller Mauller approved these changes

Assignees

@Skyaero42 Skyaero42

Labels

Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing Stability Concerns stability of the runtime

Projects

None yet

Milestone

Stability fixes

Development

Successfully merging this pull request may close these issues.

3 participants

@Skyaero42 @xezon @Mauller