bugfix(object): Reward unit experience for kills caused by OCL objects #1634
Conversation
Stubbjax
added
Bug
|
|
||
| #if !RETAIL_COMPATIBLE_CRC | ||
| ObjectID sinkID = sourceObj->getExperienceTracker()->getExperienceSink(); | ||
| firstObject->getExperienceTracker()->setExperienceSink(sinkID != INVALID_ID ? sinkID : sourceObj->getID()); |
There was a problem hiding this comment.
Can we make this INI configurable? Edit: I think it needs to be, because it changes balance quite a bit. For example Dragon Tanks will become much faster promoted.
There was a problem hiding this comment.
We can. But is that not something that can be also tweaked by INI data?
Object ChinaTankDragon
- ExperienceRequired = 0 100 150 300
+ ExperienceRequired = 0 150 250 400
EndI'd suggest earned experience is always desirable, whereas any associated balance implications are not so clear. Thus, it makes greater sense to adjust the balance in accordance with consistently earned experience, rather than making said experience optional for effectively arbitrary cases.
There was a problem hiding this comment.
True, these values can be tweaked. But will this be sufficient to avoid Pro Players jumping fences?
Can you collect all original game object names that would need ExperienceRequired potentially tweaked because of this change?
There was a problem hiding this comment.
I believe this would currently have the greatest impact on the following units:
- Alpha Aurora (fuel-air bomb)
- Dragon Tank (fire wall)
- Inferno Cannon (fire field / firestorm)
- Helix (firestorm)
- Mig (fire field / firestorm)
And a minor impact on the following units:
- Nuke Battlemaster (radiation field)
- Nuke Overlord (radiation field)
- Nuke Cannon (radiation field)
- Scud Launcher (toxin field)
- Toxin Tractor (toxin field)
- Scorpion (toxin shells)
- Marauder (toxin shells)
There was a problem hiding this comment.
These should be all the object names.
SupW_AmericaJetAurora
ChinaTankDragon
Infa_ChinaTankDragon
Nuke_ChinaTankDragon
Tank_ChinaTankDragon
ChinaVehicleInfernoCannon
Infa_ChinaVehicleInfernoCannon
Nuke_ChinaVehicleInfernoCannon
ChinaVehicleHelix
Infa_ChinaVehicleHelix
Tank_ChinaVehicleHelix
ChinaJetMIG
Infa_ChinaJetMIG
Tank_ChinaJetMIG
Nuke_ChinaTankBattleMaster
Nuke_ChinaTankOverlord
ChinaVehicleNukeLauncher
Infa_ChinaVehicleNukeLauncher
Nuke_ChinaVehicleNukeLauncher
GLAVehicleScudLauncher
Chem_GLAVehicleScudLauncher
Slth_GLAVehicleScudLauncher
GLAVehicleToxinTruck
Chem_GLAVehicleToxinTruck
Demo_GLAVehicleToxinTruck
Slth_GLAVehicleToxinTruck
GLATankScorpion
Chem_GLATankScorpion
Slth_GLATankScorpion
GLATankMarauder
Chem_GLATankMarauder
Slth_GLATankMarauder
There was a problem hiding this comment.
Alpha Aurora getting this buff is pure comedy :D
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| #if !RETAIL_COMPATIBLE_CRC | ||
| ObjectID sinkID = sourceObj->getExperienceTracker()->getExperienceSink(); | ||
| firstObject->getExperienceTracker()->setExperienceSink(sinkID != INVALID_ID ? sinkID : sourceObj->getID()); |
There was a problem hiding this comment.
Why can this have 2 types of sink sources?
There was a problem hiding this comment.
A projectile has its sink source set to the launcher in order to award experience to the launcher, so there is an experience sink defined - which the OCL will then use. However, if the OCL is produced by the launcher itself and not from a projectile, then there is no experience sink defined, and so it is directly assigned to the launcher.
xezon
changed the title
xezon
changed the title
2 participants
Fixes #283 from the patch repository
Fixes #917 from the patch repository
Fixes #1687 from the patch repository
This change allows deaths caused via OCL objects to yield experience to their creators.
This covers OCLs such as:
FIRESTORM_XP.mp4
FIREWALL_XP.mp4
RADIATION_XP.mp4
FAB_XP.mp4