bugfix(behavior): Fix unexpected propaganda influence from contained units with direct Propaganda Tower behavior modules

[Stubbjax]

This change fixes an issue where propaganda effects persist for contained units that have a direct PropagandaTowerBehavior module (e.g. Attack Outpost, Assault Troop Crawler).

The contained tower logic was only ever anticipated to be used for the Overlord's tower attachment, which is technically considered as a 'contained' passenger by the Overlord - hence the need for the two container checks. However, as the PropagandaTowerBehavior module can be added directly to units themselves, the container check does not function correctly for singular containers.

In the 1.04 example below, an Assault Troop Crawler enters a tunnel and its propaganda effect persists for units around the tunnel:

[xezon]

This change correctly identifies the cause of the issue, but the fix is not properly implemented.

The KindOf inside the Contain module is configurable in INI:

  Behavior = HelixContain ModuleTag_09
    Slots                     = 1
    DamagePercentToUnits      = 100%
    AllowInsideKindOf         = PORTABLE_STRUCTURE
    PassengersAllowedToFire   = Yes
  End

Therefore, hardcoding this KindOf is not right.

The correct way to test is in the contain module via ContainModuleInterface::isSpecialOverlordStyleContainer. An example of how this is used can be seen in TransportContain::isPassengerAllowedToFire.

Therefore, I have created new change #1609.

[Stubbjax]

Oh right, isSpecialOverlordStyleContainer is what I was looking for, though it hardly feels any more generic.

[Stubbjax]

I believe I have figured out a more comprehensive solution that covers all cases.

PROP.mp4