[GEN][ZH] Fix Hero Radar issues introduced by #1035

[xezon]

• Follow up for [GEN][ZH] Fix heap-use-after-free in W3DRadar::drawHeroIcon() #1035

This change fixes 2 issues that were introduced by #1035.

Issue 1

Hero icons from team mates or enemies were visible on the Radar. This issue happened because the changed code incorrectly added all Hero objects to m_cachedHeroObjectList, and not just those that are isLocallyControlled.

Issue 2

Using Saveload with Hero units could crash the game. I suspect this happened because after xfer not all objects were purged from m_cachedHeroObjectList. The new code will now rebuild m_cachedHeroObjectList after xfer load, because that also rebuilt the underlying radar object lists.

TODO

• Replicate in Generals

[Caball009]

Would you mind adding a bit more information about the fixes?

EDIT: I think the issue description speaks for itself, but the code might not.

[Mauller]

Okay, so this fixes the crash problem and likely the issue with enemy heroes always showing on the radar.

So one thing i did notice from this is that Observers don't get hero icons showing on the radar.
The hero icons showing when i was playing back GR1 made me notice them more.

I wonder if there is some logic broken elsewhere that is stopping "revealed" heroes from showing for players and observers.

[xezon]

The condition for showing hero icons is object->isLocallyControlled().

[Mauller]

The condition for showing hero icons is object->isLocallyControlled().

Yeah i just noticed that, so hero icons were only ever meant to show up for your own heroes and not all revealed heroes.

It was actually quite nice to spot all heroes when as an observer. Could be a nice feature to add later on.

[Mauller]

It fixes both issues with crashing on load and in the replay that was crashing.

The game crash was likely due to enemy heroes being on another players radar when they should not have been.

[xezon]

Would you mind adding a bit more information about the fixes?

Done.

[Mauller]

The condition for showing hero icons is object->isLocallyControlled().

Just doing the following lets it work for observers

if( obj->isLocallyControlled() || ThePlayerList->getLocalPlayer()->isPlayerObserver() )

It is quite neat being able to see where heroes are during a replay.

[xezon]

Yeah it's nice.

[Mauller]

Yeah it's nice.

It's also what caused the crash when the hero was in the tunnel system in the replay. lol
Fish hero tunnel radar crash.zip