Skip to content

Fixed #69 [BUG] tabs reload way too easily in the "Search" page #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed #69 [BUG] tabs reload way too easily in the "Search" page #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions lib/search/search.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,20 @@ class _ResultsScreenState extends State<_ResultsScreen> with SingleTickerProvide
final FocusNode _focusNode = FocusNode();

late TabController _tabController;
late final SearchTweetsModel _topTweetsModel;
late final SearchTweetsModel _latestTweetsModel;
late final SearchUsersModel _searchUsersModel;

@override
void initState() {
super.initState();

_tabController = TabController(length: 3, vsync: this, initialIndex: widget.initialTab);

_topTweetsModel = SearchTweetsModel();
_latestTweetsModel = SearchTweetsModel();
_searchUsersModel = SearchUsersModel();

//_bothControllers = CombinedChangeNotifier(_tabController, _queryController);

if (widget.focusInputOnOpen) {
Expand Down Expand Up @@ -96,7 +104,7 @@ class _ResultsScreenState extends State<_ResultsScreen> with SingleTickerProvide
icon: Icon(Icons.trending_up),
),
Tab(
icon: Icon(Icons.search),
icon: Icon(Icons.access_time_outlined),
),
Tab(
icon: Icon(Icons.person_search),
Expand All @@ -119,22 +127,22 @@ class _ResultsScreenState extends State<_ResultsScreen> with SingleTickerProvide
child: TabBarView(controller: _tabController, children: [
TweetSearchResultList<SearchTweetsModel, TweetWithCard>(
queryController: _queryController,
store: context.read<SearchTweetsModel>(),
searchFunction: (q) => context.read<SearchTweetsModel>().searchTweets(q, "Top"),
store: _topTweetsModel,
searchFunction: (q) => _topTweetsModel.searchTweets(q, "Top"),
itemBuilder: (context, item) {
return TweetTile(tweet: item, clickable: true);
}),
TweetSearchResultList<SearchTweetsModel, TweetWithCard>(
queryController: _queryController,
store: context.read<SearchTweetsModel>(),
searchFunction: (q) => context.read<SearchTweetsModel>().searchTweets(q, "Latest"),
store: _latestTweetsModel,
searchFunction: (q) => _latestTweetsModel.searchTweets(q, "Latest"),
itemBuilder: (context, item) {
return TweetTile(tweet: item, clickable: true);
}),
TweetSearchResultList<SearchUsersModel, UserWithExtra>(
queryController: _queryController,
store: context.read<SearchUsersModel>(),
searchFunction: (q) => context.read<SearchUsersModel>().searchUsers(q, context),
store: _searchUsersModel,
searchFunction: (q) => _searchUsersModel.searchUsers(q, context),
itemBuilder: (context, user) {
return UserTile(user: UserSubscription.fromUser(user));
}),
Expand Down