Skip to content

Removed default experience in the settings #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Removed default experience in the settings #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Source/GameBaseFramework/Private/GameFramework/GBFGameMode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,11 @@ void AGBFGameMode::HandleMatchAssignmentIfNotExpectingOne()
return;
}

experience_id = GetDefault< UGameBaseFrameworkDeveloperSettings >()->DefaultExperience;
experience_id_source = TEXT( "Default" );
// There's a todo in lyra that says: Pull this from a config setting or something
// Do we want that? Shouldn't all maps have an experience defined?
/*experience_id = FPrimaryAssetId( FPrimaryAssetType( "LyraExperienceDefinition" ), FName( "B_LyraDefaultExperience" ) );
experience_id_source = TEXT( "Default" );*/
return;
}

OnExperienceDefined( experience_id, experience_id_source );
Expand Down
3 changes: 0 additions & 3 deletions Source/GameBaseFramework/Public/GameBaseFrameworkDeveloperSettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ class UGameBaseFrameworkDeveloperSettings : public UDeveloperSettings
UPROPERTY( config, EditAnywhere, Category = "Cheats" )
TArray< FGBFCheatToRun > CheatsToRun;

UPROPERTY( EditDefaultsOnly, BlueprintReadOnly, config, Category = "Experience", meta = ( AllowedTypes = "ExperienceDefinition" ) )
FPrimaryAssetId DefaultExperience;

// The experience override to use for Play in Editor (if not set, the default for the world settings of the open map will be used)
UPROPERTY( EditDefaultsOnly, BlueprintReadOnly, config, Category = "Experience", meta = ( AllowedTypes = "ExperienceDefinition" ) )
FPrimaryAssetId ExperienceOverride;
Expand Down