Skip to content

Use FTimerDelegate in delayed save game to avoid thread-race issues #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Use FTimerDelegate in delayed save game to avoid thread-race issues #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Source/GameBaseFramework/Private/GameFramework/SaveGame/GBFSaveGameSubsystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "GameFramework/SaveGame/GBFSaveGameSubsystem.h"

#include "Async/Async.h"
#include "GBFTags.h"
#include "GameFramework/GBFWorldSettings.h"
#include "GameFramework/SaveGame/GBFSaveGame.h"
Expand Down Expand Up @@ -147,19 +148,21 @@ bool UGBFSaveGameSubsystem::Save( FGBFOnSaveGameSaved on_save_game_saved )

void UGBFSaveGameSubsystem::SaveNextTick( FGBFOnSaveGameSaved on_save_game_saved )
{
GetWorld()->GetTimerManager().SetTimerForNextTick( FTimerDelegate::CreateLambda( [ & ]() {
Save( on_save_game_saved );
} ) );
// :NOTE: Using FTimerDelegate to avoid thread-race issues
FTimerDelegate delegate;
delegate.BindUFunction( this, "Save", on_save_game_saved );

GetWorld()->GetTimerManager().SetTimerForNextTick( delegate );
}

void UGBFSaveGameSubsystem::SaveWithDelay( float delay, FGBFOnSaveGameSaved on_save_game_saved )
{
// :NOTE: Using FTimerDelegate to avoid thread-race issues
FTimerHandle handle;
GetWorld()->GetTimerManager().SetTimer( handle, FTimerDelegate::CreateLambda( [ & ]() {
Save( on_save_game_saved );
} ),
delay,
false );
FTimerDelegate delegate;
delegate.BindUFunction( this, "Save", on_save_game_saved );

GetWorld()->GetTimerManager().SetTimer( handle, delegate, delay, false );
}

void UGBFSaveGameSubsystem::Reset()
Expand Down