Skip to content

fix add abilities GameFeatureAction properly get ASC #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

fix add abilities GameFeatureAction properly get ASC #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0066107
fix add abilities GameFeatureAction properly get ASC
Apr 14, 2025
25bae1b
clang
Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/GameBaseFramework/Private/GameFeatures/GBFGameFeatureAction_AddAbilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "DVEDataValidator.h"
#endif

#include <AbilitySystemBlueprintLibrary.h>
#include <AbilitySystemComponent.h>

#define LOCTEXT_NAMESPACE "UGBFGameFeatureAction_AddAbilities"
Expand Down Expand Up @@ -224,7 +225,7 @@ void UGBFGameFeatureAction_AddAbilities::AddActorAbilities( AActor * actor, cons
return;
}

if ( auto * ability_system_component = FindOrAddComponentForActor< UAbilitySystemComponent >( actor, abilities_entry, active_data ) )
if ( auto * ability_system_component = UAbilitySystemBlueprintLibrary::GetAbilitySystemComponent( actor ) )
{
FActorExtensions AddedExtensions;
AddedExtensions.Abilities.Reserve( abilities_entry.GrantedAbilities.Num() );
Expand Down Expand Up @@ -292,6 +293,10 @@ void UGBFGameFeatureAction_AddAbilities::AddActorAbilities( AActor * actor, cons

active_data.ActiveExtensions.Add( actor, AddedExtensions );
}
else
{
UE_LOG( LogGameFeatures, Error, TEXT( "Failed to find `AbilitySystemComponent` for given actor. `Add abilities` GameFeature Action will not be processed" ) );
}
}

void UGBFGameFeatureAction_AddAbilities::RemoveActorAbilities( AActor * actor, FPerContextData & active_data )
Expand Down