Skip to content

Abilityset blueprint functions #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

Frickerson
Copy link
Collaborator

@Frickerson Frickerson commented May 28, 2024

This change is Reviewable

MaxDaniels
MaxDaniels previously approved these changes May 28, 2024
Copy link
Owner

@TheEmidee TheEmidee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Fr0oZzFred, @ThibNach, and @VectorGamez)


Source/GameBaseFramework/Public/GAS/Abilities/GBFAbilitySet.h line 83 at r1 (raw file):

public:
    UFUNCTION( BlueprintCallable, BlueprintPure = false )
    void GiveToAbilitySystem( UAbilitySystemComponent * asc, UPARAM( ref ) FGBFAbilitySet_GrantedHandles & out_granted_handles, UObject * source_object = nullptr ) const;

Prefix with K2_ to avoid any unintentional use in C++ (and use the Display Name to remove K2_)


Source/GameBaseFramework/Public/GAS/Abilities/GBFAbilitySet.h line 86 at r1 (raw file):

    UFUNCTION( BlueprintCallable )
    void TakeFromAbilitySystem( UAbilitySystemComponent * asc, UPARAM( ref ) FGBFAbilitySet_GrantedHandles & granted_handles );

same

Copy link
Collaborator Author

@Frickerson Frickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Fr0oZzFred, @TheEmidee, and @ThibNach)


Source/GameBaseFramework/Public/GAS/Abilities/GBFAbilitySet.h line 83 at r1 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

Prefix with K2_ to avoid any unintentional use in C++ (and use the Display Name to remove K2_)

Done.


Source/GameBaseFramework/Public/GAS/Abilities/GBFAbilitySet.h line 86 at r1 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

same

Done.

Copy link
Owner

@TheEmidee TheEmidee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Fr0oZzFred and @ThibNach)

@TheEmidee TheEmidee merged commit ba2a2c3 into develop May 29, 2024
6 checks passed
@TheEmidee TheEmidee deleted the abilityset_blueprint_functions branch May 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants