Input buffer #260

Fr0oZzFred · 2024-04-29T18:22:31Z

Add input buffer

This change is

Source/GameBaseFramework/Private/Animation/GBFAnimNotifyState_InputBuffer.cpp

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp

TheEmidee

Reviewed 5 of 8 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 20 unresolved discussions (waiting on @Fr0oZzFred, @MaxDaniels, @ThibNach, and @VectorGamez)

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 8 at r3 (raw file):

#include "Input/GBFInputComponent.h"

UGBFAbilityInputBufferComponent::UGBFAbilityInputBufferComponent( const FObjectInitializer & ObjectInitializer ) :

object_initializer

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 16 at r3 (raw file):

}

void UGBFAbilityInputBufferComponent::TickComponent( float DeltaTime, ELevelTick TickType, FActorComponentTickFunction * ThisTickFunction )

CS on function parameters

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 216 at r3 (raw file):

    }

    FGameplayTag most_triggered_tag = triggered_tag_map.FindAndRemoveChecked( max );

you could use a TSortedMap to avoid this code

Source/GameBaseFramework/Private/Characters/Components/GBFHeroComponent.cpp line 227 at r3 (raw file):

}

TMap< const UGBFInputConfig *, TArray< uint32 > > UGBFHeroComponent::GetBoundActionsByInputconfig() const

return by const XXX & to avoid a copy

Source/GameBaseFramework/Private/GAS/Components/GBFAbilitySystemComponent.cpp line 382 at r3 (raw file):

}

UGameplayAbility * UGBFAbilitySystemComponent::FindAbilityClassWithInputTag( FGameplayTag input_tag )

FindAbilityByInputTag

Source/GameBaseFramework/Private/GAS/Components/GBFAbilitySystemComponent.cpp line 382 at r3 (raw file):

}

UGameplayAbility * UGBFAbilitySystemComponent::FindAbilityClassWithInputTag( FGameplayTag input_tag )

the function can be const

Source/GameBaseFramework/Public/Animation/GBFAnimNotifyState_InputBuffer.h line 5 at r3 (raw file):

#include "Characters/Components/GBFAbilityInputBufferComponent.h"

#include <Animation/AnimNotifies/AnimNotifyState.h>

<>

Source/GameBaseFramework/Public/Animation/GBFAnimNotifyState_InputBuffer.h line 28 at r3 (raw file):

    UPROPERTY( EditAnywhere )
    ETriggerPriority TriggerPriority;
    UPROPERTY( EditAnywhere, Meta = ( Categories = "Input" ) )

missing empty line

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h line 17 at r3 (raw file):

UCLASS( Blueprintable )
class GAMEBASEFRAMEWORK_API UGBFAbilityInputBufferComponent : public UPawnComponent

final

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h line 24 at r3 (raw file):

    UGBFAbilityInputBufferComponent( const FObjectInitializer & ObjectInitializer );
    void TickComponent( float DeltaTime, ELevelTick TickType, FActorComponentTickFunction * ThisTickFunction ) override;
    UFUNCTION( BlueprintCallable )

empty line above

Frickerson · 2024-05-06T12:26:02Z

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp

+{
+    Super::TickComponent( DeltaTime, TickType, ThisTickFunction );
+    MonitoringTime += DeltaTime;
+    if ( !ensureAlwaysMsgf( MonitoringTime <= MaxMonitoringTime, TEXT( "Ability Input Buffer didn't call Stop Monitor 5 secs after activation, please call it manually !" ) ) )


print the actual MaxMonitoringTime instead of 5

Frickerson · 2024-05-06T12:28:08Z

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp

+    this->PrimaryComponentTick.bCanEverTick = true;
+}
+
+void UGBFAbilityInputBufferComponent::TickComponent( float DeltaTime, ELevelTick TickType, FActorComponentTickFunction * ThisTickFunction )


Since the tick would only be fired #if !UE_BUILD_SHIPPING, you can surround the function by that too, both in .h and cpp

Frickerson · 2024-05-06T12:28:55Z

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h

 public:
+    UGBFAbilityInputBufferComponent( const FObjectInitializer & ObjectInitializer );
+    void TickComponent( float DeltaTime, ELevelTick TickType, FActorComponentTickFunction * ThisTickFunction ) override;
    UFUNCTION( BlueprintCallable )


UFUNCTION before other functions, except for constructor and inline functions

Frickerson · 2024-05-06T12:29:52Z

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h

@@ -38,4 +41,8 @@ class GAMEBASEFRAMEWORK_API UGBFAbilityInputBufferComponent : public UPawnCompon
    FGameplayTagContainer InputTagsToCheck;
    TArray< FGameplayTag > TriggeredTags;
    TArray< uint32 > BindHandles;
-};
+
+    UPROPERTY( EditDefaultsOnly )


UPROPERTY before all other properties

Frickerson

Reviewed all commit messages.
Reviewable status: all files reviewed, 14 unresolved discussions (waiting on @Fr0oZzFred, @MaxDaniels, and @ThibNach)

Frickerson

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 12 unresolved discussions (waiting on @Fr0oZzFred, @MaxDaniels, and @ThibNach)

Fr0oZzFred

Reviewable status: all files reviewed, 12 unresolved discussions (waiting on @MaxDaniels, @TheEmidee, @ThibNach, and @VectorGamez)

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 8 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

object_initializer

Done.

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 16 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

CS on function parameters

Done.

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 16 at r3 (raw file):

Previously, VectorGamez (Viktor Blomme) wrote…

Since the tick would only be fired #if !UE_BUILD_SHIPPING, you can surround the function by that too, both in .h and cpp

Done.

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 20 at r3 (raw file):

Previously, VectorGamez (Viktor Blomme) wrote…

print the actual MaxMonitoringTime instead of 5

Done.

Source/GameBaseFramework/Private/Characters/Components/GBFAbilityInputBufferComponent.cpp line 216 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

you could use a TSortedMap to avoid this code

Done.

Source/GameBaseFramework/Private/Characters/Components/GBFHeroComponent.cpp line 227 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

return by const XXX & to avoid a copy

Done.

Source/GameBaseFramework/Private/GAS/Components/GBFAbilitySystemComponent.cpp line 382 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

FindAbilityByInputTag

Done.

Source/GameBaseFramework/Private/GAS/Components/GBFAbilitySystemComponent.cpp line 382 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

the function can be const

Done.

Source/GameBaseFramework/Public/Animation/GBFAnimNotifyState_InputBuffer.h line 5 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

<>

already done

Source/GameBaseFramework/Public/Animation/GBFAnimNotifyState_InputBuffer.h line 28 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

missing empty line

Done.

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h line 17 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

final

Done.

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h line 24 at r3 (raw file):

Previously, TheEmidee (Michael Delva) wrote…

empty line above

Done.

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h line 24 at r3 (raw file):

Previously, VectorGamez (Viktor Blomme) wrote…

UFUNCTION before other functions, except for constructor and inline functions

Done.

Source/GameBaseFramework/Public/Characters/Components/GBFAbilityInputBufferComponent.h line 45 at r3 (raw file):

Previously, VectorGamez (Viktor Blomme) wrote…

UPROPERTY before all other properties

Done.

TheEmidee

Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MaxDaniels, @ThibNach, and @VectorGamez)

Frédéric and others added 9 commits April 25, 2024 17:50

setup input buffer

dfadd7c

wip register triggered actions

6390933

input buffer working with one ability

4f17a39

code cleanup + trigger priority

726a242

add new priority

83458a8

fix find input buffer component

df0db85

cleanup code

72edbd4

reset + clang format

ddd7262

add blueprint callable

528ecbc

Frickerson requested changes Apr 30, 2024

View reviewed changes

review

d872059

Frickerson previously approved these changes Apr 30, 2024

View reviewed changes

Fr0oZzFred marked this pull request as draft May 6, 2024 08:48

add monitoring time verification

b1c1266

Fr0oZzFred dismissed Frickerson’s stale review via b1c1266 May 6, 2024 10:52

Fr0oZzFred marked this pull request as ready for review May 6, 2024 11:29

Fr0oZzFred requested review from TheEmidee, MaxDaniels, ThibNach and Frickerson May 10, 2024 08:18

TheEmidee requested changes May 10, 2024

View reviewed changes

Frickerson reviewed May 13, 2024

View reviewed changes

review standards

a9b11b0

Frickerson reviewed May 13, 2024

View reviewed changes

Frédéric added 3 commits May 13, 2024 11:27

sorted map

0b3e854

remove uproperty and ufunction

261a243

clang format

de401d7

Fr0oZzFred commented May 13, 2024

View reviewed changes

TheEmidee approved these changes May 13, 2024

View reviewed changes

TheEmidee merged commit d9bb431 into develop May 13, 2024
6 checks passed

TheEmidee deleted the input_buffer branch May 13, 2024 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Input buffer #260

Input buffer #260

Uh oh!

Fr0oZzFred commented Apr 29, 2024 •

edited by TheEmidee

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheEmidee left a comment

Uh oh!

Frickerson May 6, 2024

Uh oh!

Frickerson May 6, 2024

Uh oh!

Frickerson May 6, 2024

Uh oh!

Frickerson May 6, 2024

Uh oh!

Frickerson left a comment

Uh oh!

Frickerson left a comment

Uh oh!

Fr0oZzFred left a comment

Uh oh!

TheEmidee left a comment

Uh oh!

Uh oh!

Uh oh!

Input buffer #260

Input buffer #260

Uh oh!

Conversation

Fr0oZzFred commented Apr 29, 2024 • edited by TheEmidee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheEmidee left a comment

Choose a reason for hiding this comment

Uh oh!

Frickerson May 6, 2024

Choose a reason for hiding this comment

Uh oh!

Frickerson May 6, 2024

Choose a reason for hiding this comment

Uh oh!

Frickerson May 6, 2024

Choose a reason for hiding this comment

Uh oh!

Frickerson May 6, 2024

Choose a reason for hiding this comment

Uh oh!

Frickerson left a comment

Choose a reason for hiding this comment

Uh oh!

Frickerson left a comment

Choose a reason for hiding this comment

Uh oh!

Fr0oZzFred left a comment

Choose a reason for hiding this comment

Uh oh!

TheEmidee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Fr0oZzFred commented Apr 29, 2024 •

edited by TheEmidee

Loading