Add support for js snippets #527
Conversation
DaAlbrecht
added
C-Feature
There was a problem hiding this comment.
Very cool, didn't know this feature existed! Thanks for working on this.
I created a test package and it works as expected.
Just have one suggestion, but otherwise it's good to go :)
| &format!("/build/{}", wasm_file_name.to_str().unwrap()), | ||
| ServeFile::new(build_artifact_path.join(wasm_file_name)), | ||
| ) | ||
| .nest_service("/build", ServeDir::new(build_artifact_path)) |
There was a problem hiding this comment.
I'm not sure if it's a good idea to include the entire build artifact folder here. It can contain a lot of different files from many different binaries.
While this is for dev only, I think it would be best if we emulated the same environment as the packaged bundle, which wouldn't include the entire build folder
There was a problem hiding this comment.
I don't see it as a problem, it just means that we correctly route to any file that is needed in the folder. This makes us more robust to potential changes in the file layout.
The main reason I did it this way is that we don't know up front which snippets are included by wasm-bindgen, and that the snippet directories include the hash of the files. I think it would be quite complicated to get that information, for very little gain.
|
Oh, can you also add an entry to the |
wasm-bindgen has a feature called js snippets, see https://rustwasm.github.io/wasm-bindgen/reference/js-snippets.html. This PR makes bevy cli take these files into account both when serving and bundling.