Skip to content

fix(issue-96): use oid_registry crate #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

fix(issue-96): use oid_registry crate #97

merged 1 commit into from
May 24, 2025

Conversation

RageKnify
Copy link
Contributor

Introduce oid_registry as a dependency to manage the mapping of ASN1 oids.

Closes #96

@RageKnify
Copy link
Contributor Author

Small warning, I have realized that this isn't exactly backwards compatible, as an example the oid 1.3.14.3.2.26 (hex encoded 06052b0e03021a) used to display hashAlgorithmIdentifier and will now be id-SHA1

TheBestTvarynka
TheBestTvarynka approved these changes May 17, 2025
View reviewed changes
Copy link
Owner

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thank you for your PR 💟 . The code looks great to me. I'll test it tomorrow and then merge if everything is good.

@TheBestTvarynka
Copy link
Owner

TheBestTvarynka commented May 17, 2025 •
edited
Loading

@RageKnify I allowed the CI. Please, fix formatting (cargo +nightly fmt) 🙏

@TheBestTvarynka TheBestTvarynka added enhancement Changes that affects all report or any general component asn1-parser Changes in the asn1-parser labels May 17, 2025
@RageKnify
fix(issue-96): use oid_registry crate
9f64a9e 
Introduce oid_registry as a dependency to manage the mapping of
ASN1 oids.

Closes TheBestTvarynka#96
@RageKnify RageKnify force-pushed the refactor/oid-registry branch from 7c1574a to 9f64a9e Compare May 18, 2025 15:23
@TheBestTvarynka TheBestTvarynka merged commit 0a0561a into TheBestTvarynka:main May 24, 2025
1 check passed
@TheBestTvarynka
Copy link
Owner

@RageKnify Thank you!

TheBestTvarynka added a commit that referenced this pull request May 28, 2025
@TheBestTvarynka
Revert "fix(issue-96): use oid_registry crate (#97)"
62ae442 
This reverts commit 0a0561a.
@TheBestTvarynka TheBestTvarynka mentioned this pull request May 28, 2025
Merged
TheBestTvarynka added a commit that referenced this pull request May 28, 2025
@TheBestTvarynka
Revert "fix(issue-96): use oid_registry crate (#97)" (#98)
d5f2efb
@RageKnify RageKnify deleted the refactor/oid-registry branch May 29, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBestTvarynka TheBestTvarynka TheBestTvarynka approved these changes

Assignees

@RageKnify RageKnify

Labels

asn1-parser Changes in the asn1-parser enhancement Changes that affects all report or any general component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace hardcoded OID values with oid_registry crate

2 participants

@RageKnify @TheBestTvarynka