Skip to content

Conversation

grok-rs
Copy link
Contributor

@grok-rs grok-rs commented Mar 9, 2025

image

This pull request introduces a validation check in the BitString decoder to explicitly reject any BitString with no content bytes

Test string

6065060a2a864886f7120102020303007e553053a003020105a10302011ea411180f32303235303230383130333035365aa5050203056b0ea603020129a9091b075442542e434f4daa1d301ba003020101a11430121b1077696e2d39353663716f73736a746624

closes #88

@TheBestTvarynka TheBestTvarynka self-requested a review March 10, 2025 21:31
@TheBestTvarynka TheBestTvarynka added the asn1-parser Changes in the asn1-parser label Mar 10, 2025
Copy link
Owner

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good code. Thank you 👍

Copy link
Owner

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheBestTvarynka TheBestTvarynka merged commit 2fce639 into TheBestTvarynka:main Mar 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asn1-parser Changes in the asn1-parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic during ASN1 data parsing

2 participants