Skip to content

Conversation

HarshPathak310
Copy link
Contributor

Describe your change:

1)Logical Issue in predict() Function

previous code: elif self.left or self.right is not None:
doesn’t actually do what you think.
It will always be True, because self.left might exist even if self.right is None.
new code:elif self.left is not None and self.right is not None:

2)Minor Fix — Avoid Ambiguous None Return in predict()
If the tree isn’t trained, you currently print an error and return None.
Instead, you should raise a clear exception:
new code: raise ValueError("Decision tree not yet trained")

3)Naming Improvements:
fix typo in docstring name:
new code:doctest.testmod(name="mean_squared_error", verbose=True)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 7, 2025
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 17, 2025
@MaximSmolskiy MaximSmolskiy merged commit c79034c into TheAlgorithms:master Oct 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants